Next15 support #125
Merged
Next15 support #125
+681
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thomasballinger
force-pushed
the
next15-support
branch
from
3294ff5
to
3f2dee3
Compare
commit: |
thomasballinger
force-pushed
the
next15-support
branch
from
ffdf259
to
f1626fd
Compare
|
Iterating separately from Chadwick's branch, #118 |
sshader
approved these changes
Nov 27, 2024
|
Just manually tested, looks good with a Next.js 14 site. |
thomasballinger
force-pushed
the
next15-support
branch
from
6ac4bca
to
a42eded
Compare
Closed
edproton
reviewed
Nov 29, 2024
| @@ -28,10 +26,10 @@ const isSignInPage = createRouteMatcher(["/signin"]); | |||
| const isProtectedRoute = createRouteMatcher(["/product(.*)"]); | |||
|
|
|||
| export default convexAuthNextjsMiddleware((request, { convexAuth }) => { | |||
There was a problem hiding this comment.
The arrow function is lacking async here.
It should be
export default convexAuthNextjsMiddleware(async (request, { convexAuth }) => {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.