Skip to content

Commit

Permalink
Add a fivetran-import client type (#23679)
Browse files Browse the repository at this point in the history
This pull request adds a new `fivetran-import` client type.

GitOrigin-RevId: a37045e7c0b001b90cf562f2d1b3ebffa2712c7d
  • Loading branch information
Nicolapps authored and Convex, Inc. committed Mar 20, 2024
1 parent 0575cd3 commit 1b1652c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
6 changes: 6 additions & 0 deletions crates/common/src/version.rs
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ pub enum ClientType {
Rust,
StreamingImport,
AirbyteExport,
FivetranImport,
FivetranExport,
Unrecognized(String),
}
Expand Down Expand Up @@ -137,6 +138,7 @@ impl Display for ClientType {
Self::Rust => write!(f, "rust"),
Self::StreamingImport => write!(f, "streaming-import"),
Self::AirbyteExport => write!(f, "airbyte-export"),
Self::FivetranImport => write!(f, "fivetran-import"),
Self::FivetranExport => write!(f, "fivetran-export"),
Self::Unrecognized(other_client) => write!(f, "{other_client}"),
}
Expand All @@ -152,6 +154,7 @@ impl ClientType {
Self::Rust => Some(rust.upgrade_required.clone()),
Self::StreamingImport
| Self::AirbyteExport
| Self::FivetranImport
| Self::FivetranExport
| Self::Unrecognized(_) => None,
}
Expand All @@ -165,6 +168,7 @@ impl ClientType {
Self::Rust => Some(rust.unsupported.clone()),
Self::StreamingImport
| Self::AirbyteExport
| Self::FivetranImport
| Self::FivetranExport
| Self::Unrecognized(_) => None,
}
Expand All @@ -184,6 +188,7 @@ impl ClientType {
},
Self::StreamingImport
| Self::AirbyteExport
| Self::FivetranImport
| Self::FivetranExport
| Self::Unrecognized(_) => "",
}
Expand Down Expand Up @@ -285,6 +290,7 @@ impl ClientVersion {
ClientType::Rust
| ClientType::StreamingImport
| ClientType::AirbyteExport
| ClientType::FivetranImport
| ClientType::FivetranExport
| ClientType::Unrecognized(_) => true,
}
Expand Down
1 change: 1 addition & 0 deletions crates/local_backend/src/subs/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,7 @@ fn new_sync_worker_config(client_version: ClientVersion) -> anyhow::Result<SyncW
| ClientType::Python
| ClientType::StreamingImport
| ClientType::AirbyteExport
| ClientType::FivetranImport
| ClientType::FivetranExport
| ClientType::Actions => Err(anyhow::anyhow!(
"No websocket support for client: {}",
Expand Down

0 comments on commit 1b1652c

Please sign in to comment.