Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 Compatibility #1981

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

Aunshon
Copy link
Collaborator

@Aunshon Aunshon commented Aug 22, 2023

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Compatibility support php 8.2

How to test the changes in this Pull Request:

  1. Find warnings for php 8.2

Changelog entry

PHP 8.2 Compatibility

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@Aunshon Aunshon added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval Dependency With Pro labels Aug 22, 2023
@Aunshon Aunshon self-assigned this Aug 22, 2023
@nurul-umbhiya nurul-umbhiya added 👍 Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Aug 25, 2023
@shashwatahalder01 shashwatahalder01 added QA In Progress Needs: Testing This requires further testing In Progress The issues is being worked on and removed Needs: Testing This requires further testing QA In Progress 👍 Dev Review Done labels Oct 9, 2023
@Aunshon Aunshon removed the In Progress The issues is being worked on label Oct 10, 2023
@shashwatahalder01 shashwatahalder01 added QA In Progress QA approved This PR is approved by the QA team and removed Needs: Testing This requires further testing QA In Progress labels Nov 22, 2023
@shashwatahalder01 shashwatahalder01 added QA approved This PR is approved by the QA team and removed QA approved This PR is approved by the QA team labels Dec 5, 2023
@nurul-umbhiya nurul-umbhiya merged commit 23f6920 into getdokan:develop Dec 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excessive amount of deprecated notices in PHP 8.2 with Dokan Stripe express
3 participants