Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: email placeholder, additional content support and formatting #1985

Merged
merged 24 commits into from
Mar 27, 2024
Merged

refactor: email placeholder, additional content support and formatting #1985

merged 24 commits into from
Mar 27, 2024

Conversation

shohag121
Copy link
Member

@shohag121 shohag121 commented Aug 25, 2023 •
edited
Loading

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

  1. check issue https://github.com/weDevsOfficial/dokan-pro/issues/2465

Changelog entry

No change log needed

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@shohag121 shohag121 added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval labels Aug 25, 2023
@shohag121 shohag121 self-assigned this Aug 25, 2023
nurul-umbhiya
nurul-umbhiya suggested changes Aug 31, 2023
View reviewed changes
includes/Emails/ContactSeller.php Outdated Show resolved Hide resolved
includes/Emails/ContactSeller.php Outdated Show resolved Hide resolved
includes/Emails/NewProduct.php Outdated Show resolved Hide resolved
includes/Emails/NewProduct.php Outdated Show resolved Hide resolved
includes/Emails/NewProduct.php Outdated Show resolved Hide resolved
includes/Emails/NewProduct.php Outdated Show resolved Hide resolved
includes/Emails/NewSeller.php Outdated Show resolved Hide resolved
includes/Emails/ReverseWithdrawalInvoice.php Outdated Show resolved Hide resolved
includes/Emails/VendorWithdrawRequest.php Outdated Show resolved Hide resolved
includes/Emails/VendorWithdrawRequest.php Outdated Show resolved Hide resolved
@nurul-umbhiya nurul-umbhiya added Needs: Author Reply and removed Needs: Dev Review It requires a developer review and approval labels Aug 31, 2023
@shohag121 shohag121 added Needs: Dev Review It requires a developer review and approval and removed Needs: Author Reply labels Sep 11, 2023
@shohag121
Merge branch 'develop' into update/email-rafactors
5f48d68 
# Conflicts:
#	includes/Emails/NewProduct.php
#	includes/Emails/NewProductPending.php
@shohag121
refactor: redundant product check removed
a1c8b09
nurul-umbhiya
nurul-umbhiya suggested changes Sep 15, 2023
View reviewed changes
includes/Emails/ContactSeller.php Show resolved Hide resolved
includes/Emails/ContactSeller.php Show resolved Hide resolved
includes/Emails/ContactSeller.php Outdated Show resolved Hide resolved
includes/Emails/NewProduct.php Show resolved Hide resolved
includes/Emails/NewSeller.php Show resolved Hide resolved
includes/Emails/WithdrawApproved.php Outdated Show resolved Hide resolved
includes/Emails/WithdrawCancelled.php Outdated Show resolved Hide resolved
includes/ReverseWithdrawal/BackgroundProcess/AsyncRequests.php Show resolved Hide resolved
includes/Vendor/Vendor.php Outdated Show resolved Hide resolved
templates/emails/plain/contact-seller.php Show resolved Hide resolved
@nurul-umbhiya nurul-umbhiya added 👍 Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Oct 4, 2023
@shohag121
Copy link
Member Author

@shashwatahalder01 Bhai, Can you please test this PR?

@shashwatahalder01 shashwatahalder01 removed the Needs: Testing This requires further testing label Nov 20, 2023
@shohag121 shohag121 added the Needs: Testing This requires further testing label Dec 28, 2023
@shashwatahalder01 shashwatahalder01 added QA In Progress and removed Needs: Testing This requires further testing labels Jan 1, 2024
@shashwatahalder01

This comment was marked as resolved.

Sign in to view
@shashwatahalder01

This comment was marked as resolved.

Sign in to view
@shashwatahalder01

This comment was marked as resolved.

Sign in to view
@shashwatahalder01

This comment was marked as resolved.

Sign in to view
@shashwatahalder01

This comment was marked as resolved.

Sign in to view
@shashwatahalder01

This comment was marked as resolved.

Sign in to view
@shashwatahalder01 shashwatahalder01 added Needs: Testing This requires further testing and removed QA In Progress labels Jan 19, 2024
@shashwatahalder01 shashwatahalder01 added QA In Progress Needs: Testing This requires further testing and removed Needs: Testing This requires further testing QA In Progress labels Feb 20, 2024
@shashwatahalder01 shashwatahalder01 added QA In Progress and removed Needs: Testing This requires further testing labels Mar 12, 2024
@shashwatahalder01 shashwatahalder01 added QA approved This PR is approved by the QA team and removed QA In Progress labels Mar 21, 2024
@shohag121 shohag121 merged commit 61e8a7d into getdokan:develop Mar 27, 2024
0 of 2 checks passed
@danielbreves danielbreves mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nurul-umbhiya nurul-umbhiya nurul-umbhiya approved these changes

Assignees

@shohag121 shohag121

Labels
QA approved This PR is approved by the QA team 👍 Dev Review Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dokan New Withdrawal Request Email - Vendor Name fields show the user name instead
3 participants
@shohag121 @shashwatahalder01 @nurul-umbhiya