-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added media support for Product Short description and description. #2317
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThe recent changes primarily involve updating URLs in a WordPress plugin to reflect a new domain, from Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- templates/products/edit-product-single.php (2 hunks)
Additional comments not posted (2)
templates/products/edit-product-single.php (2)
438-438
: Approved: Enabled media buttons for short description.This change enhances the user experience by allowing media to be added directly in the editor for the short description.
458-458
: Approved: Enabled media buttons for long description.This change enhances the user experience by allowing media to be added directly in the editor for the long description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- includes/Admin/Settings.php (6 hunks)
- templates/admin-header.php (3 hunks)
Additional comments not posted (10)
templates/admin-header.php (4)
36-36
: URL update approved.The URL has been correctly updated to
https://app.dokan.co/support/create/?utm_source=plugin&utm_medium=wp-admin&utm_campaign=dokan-lite
.
57-57
: URL update approved.The URL has been correctly updated to
https://dokan.co/docs/wordpress/getting-started/?utm_source=plugin&utm_medium=wp-admin&utm_campaign=dokan-lite
.
82-82
: URL update approved.The URL has been correctly updated to
https://dokan.co/wordpress/feature-requests/
.
Line range hint
302-302
:
URL update approved.The URL has been correctly updated to
https://dokan.co/docs/wordpress/settings/general/
.includes/Admin/Settings.php (6)
302-302
: URL update approved.The URL has been correctly updated to
https://dokan.co/docs/wordpress/settings/general/
.
311-311
: URL update approved.The URL has been correctly updated to
https://dokan.co/docs/wordpress/settings/selling-options/
.
320-320
: URL update approved.The URL has been correctly updated to
https://dokan.co/docs/wordpress/settings/withdraw-options/
.
329-329
: URL update approved.The URL has been correctly updated to
https://dokan.co/docs/wordpress/withdraw/dokan-reverse-withdrawal/
.
338-338
: URL update approved.The URL has been correctly updated to
https://dokan.co/docs/wordpress/settings/page-settings-2/
.
347-347
: URL update approved.The URL has been correctly updated to
https://dokan.co/docs/wordpress/settings/appearance/
.
All Submissions:
Changes proposed in this Pull Request:
We can introduce media options for both short descriptions and long descriptions.
Changelog entry
Added media support for Product Short description and description.
Before Changes
Describe the issue before changes with screenshots(s).
After Changes
Vendors can add media on the product edit page.
Feature Video (optional)
Link of detailed video if this PR is for a feature.
PR Self Review Checklist:
FOR PR REVIEWER ONLY:
Summary by CodeRabbit
New Features
Updates
dokan.co
.dokan.co
domain.