mlops: make kedro mandatory again

disable kedro telemetry
getindata · Sep 13, 2024 · 70643c5 · 70643c5
1 parent 5f7d25e
commit 70643c5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/.github/workflows/build_mlops.yml b/.github/workflows/build_mlops.yml
@@ -1,6 +1,6 @@
 name: Build jupyterlab-mlops Image
 env:
-  KEDRO_DEFAULT_VERSION: "NONE"
+  KEDRO_DEFAULT_VERSION: "0.19.8"
   MLFLOW_DEFAULT_VERSION: "2.15.1"
   VSCODE_DEFAULT_VERSION: "NONE"
   PYTHON_DEFAULT_VERSION: "3.11"
@@ -50,6 +50,7 @@ jobs:
             nb-user: jupyter
           - base-image: "jupyter/minimal-notebook:python-3.11.6"
             spark-support: false
+            kedro-version: "0.19.8"
             mlflow-version: "2.15.1"
             vscode-version: "4.91.1"
             python-version: "3.11"

diff --git a/jupyterlab-mlops/Dockerfile b/jupyterlab-mlops/Dockerfile
@@ -15,7 +15,8 @@ ENV NB_USER=$USER \
     NB_GID=$GID \
     CONDA_DIR=/opt/conda \
     VSCODE_VERSION=$VSCODE_VERSION \
-    KEDRO_VERSION=$KEDRO_VERSION
+    KEDRO_VERSION=$KEDRO_VERSION \
+    KEDRO_DISABLE_TELEMETRY=true
 
 USER root
 
@@ -106,16 +107,12 @@ RUN mamba install --quiet --yes kfp jupyter-server-proxy -c conda-forge && \
     pip --no-cache-dir install mlflow==$MLFLOW_VERSION && \
     mamba clean --all -f -y
 
-# configure python env with optional kedro
-RUN if [ "${KEDRO_VERSION}" != "NONE" ]; then \
-    mamba create --quiet --yes -p "${CONDA_DIR}/envs/python${PYTHON_VERSION}" python=${PYTHON_VERSION} ipython ipykernel kedro=${KEDRO_VERSION} && \
+# configure python env with kedro
+RUN mamba create --quiet --yes -p "${CONDA_DIR}/envs/python${PYTHON_VERSION}" \
+    python=${PYTHON_VERSION} ipython ipykernel kedro=${KEDRO_VERSION} kedro-viz && \
     mamba clean --all -f -y && \
-    "${CONDA_DIR}/envs/python${PYTHON_VERSION}/bin/python" -m ipykernel install --user --name=python${PYTHON_VERSION}; \
-    else \
-    mamba create --quiet --yes -p "${CONDA_DIR}/envs/python${PYTHON_VERSION}" python=${PYTHON_VERSION} ipython ipykernel && \
-    mamba clean --all -f -y && \
-    "${CONDA_DIR}/envs/python${PYTHON_VERSION}/bin/python" -m ipykernel install --user --name=python${PYTHON_VERSION}; \
-    fi
+    "${CONDA_DIR}/envs/python${PYTHON_VERSION}/bin/python" -m ipykernel \
+    install --user --name=python${PYTHON_VERSION}
 
 RUN fix-permissions "/home/${NB_USER}" && \
     fix-permissions "${CONDA_DIR}" && \