Response: support range requests for files #5153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distantnative
added
the
type: enhancement ✨
distantnative
force-pushed
the
feature/http-range-response
branch
from
6dbbaee
to
c1dff92
Compare
distantnative
added
needs: help 🙏
distantnative
force-pushed
the
feature/http-range-response
branch
from
c1dff92
to
12f19bc
Compare
lukasbestle
reviewed
Apr 28, 2023
| $size = static::size($file); | ||
| $end ??= $size; | ||
|
|
||
| if ($end === $size) { |
There was a problem hiding this comment.
Shouldn't this also check for start being 0? Otherwise the full file is returned even when the beginning wasn't requested.
| ): void { | ||
| $size = static::size($file); | ||
| $end ??= $size; | ||
|
|
There was a problem hiding this comment.
I think there should be checks for start < 0, start >= end and end > size here as well, throwing an exception to provide extra safety and for those who use this method directly.
|
What's the state of this? Should we keep this in the lab and remove the PR? |
|
It's out here because I need help from the rest of the team. I won't get much further on my own. If this happens now or when, to be decided. |
|
Closing this for now. PR is referenced in corresponding issue and can be revisited when tackling this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a start... but I think I am at the point where I need input from others