Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for sticky table headers #6018

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Fixes for sticky table headers #6018

merged 2 commits into from
Nov 30, 2023

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Nov 29, 2023 •
edited by bastianallgeier
Loading

This PR …

Table headers in table block preview would be offset by --scroll-top value even when scroll hadn't reached them (effectively sticky positioning is broken). Visible also at https://lab.getkirby.com/public/lab/components/blocks/table

Fixes

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Nov 29, 2023
@distantnative distantnative added this to the 4.0.1 milestone Nov 29, 2023
@distantnative distantnative requested a review from a team November 29, 2023 04:25
@distantnative distantnative self-assigned this Nov 29, 2023
@distantnative distantnative linked an issue Nov 29, 2023 that may be closed by this pull request
Problem with the position of the <thead> in the item table in blocks #6016
Closed
@distantnative distantnative changed the base branch from main to develop-patch November 29, 2023 14:21
@bastianallgeier bastianallgeier merged commit 31ac829 into develop-patch Nov 30, 2023
7 checks passed
@bastianallgeier bastianallgeier deleted the fix/6016-scroll-top branch November 30, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.

Problem with the position of the <thead> in the item table in blocks
2 participants
@distantnative @bastianallgeier