Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xml::attr(): remove deprecated code #6803

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Xml::attr(): remove deprecated code #6803

merged 1 commit into from
Nov 21, 2024
+1 −17

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Nov 20, 2024 •
edited by bastianallgeier
Loading

Changelog

Breaking changes

  • Passing a single space as value to Xml::attr() won't render an empty value anymore but a single space. To render an empty value, please pass an empty string.

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: refactoring ♻️ Is about bad code; cleans up code label Nov 20, 2024
@distantnative distantnative added this to the 5.0.0-beta.1 milestone Nov 20, 2024
@distantnative distantnative self-assigned this Nov 20, 2024
@distantnative distantnative marked this pull request as ready for review November 20, 2024 17:27
@distantnative distantnative requested a review from a team November 20, 2024 17:27
@bastianallgeier bastianallgeier merged commit 14e4685 into v5/develop Nov 21, 2024
11 checks passed
@bastianallgeier bastianallgeier deleted the v5/fix/xml-attr-remove-deprecated branch November 21, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: refactoring ♻️ Is about bad code; cleans up code
Projects
None yet
Milestone
5.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier