Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview tokens 1: Groundwork A (Testing) #6821

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

lukasbestle
Copy link
Member

Description

Summary of changes

Ensure that all features of $page->render() are tested in one place

Reasoning

Provides a baseline to reduce the risk of regressions

Changelog

Housekeeping

  • Refactor page render tests out into separate test class and extend them to cover more cases

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@lukasbestle lukasbestle added the type: refactoring ♻️ Is about bad code; cleans up code label Nov 29, 2024
@lukasbestle lukasbestle added this to the 5.0.0-beta.1 milestone Nov 29, 2024
@lukasbestle lukasbestle self-assigned this Nov 29, 2024
@distantnative
Copy link
Member

Suggestion: Could we add a comment to the PageCacheTest class that now the tests for the caching in the render method can be found in the PageRenderTest class? Might help us down the road to remember/understand where to find what.

Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test improvements are really great.

@bastianallgeier bastianallgeier merged commit 15a07c4 into v5/develop Dec 2, 2024
11 checks passed
@bastianallgeier bastianallgeier deleted the v5/changes/preview-tokens-1 branch December 2, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactoring ♻️ Is about bad code; cleans up code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants