fix(docs): add instructions in how to find binaries path #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for engineering-outreach-io-stencil ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
george-e-shaw-iv
approved these changes
Dec 19, 2023
malept
requested changes
Dec 19, 2023
| @@ -31,7 +31,8 @@ A native extension can be ran locally using the `replacements` key in an applica | |||
|
|
|||
| ## Debugging a Native Extension | |||
|
|
|||
| The [`go-plugin`](https://github.com/hashicorp/go-plugin) library does not surface errors to stencil. Instead, it will raise the generic message `failed to create connection to extension: Unrecognized remote plugin message`. To determine a more precise error message, execute the native extension binary directly. | |||
| The [`go-plugin`](https://github.com/hashicorp/go-plugin) library does not surface errors to stencil. Instead, it will raise the generic message `failed to create connection to extension: Unrecognized remote plugin message`. The binary path could be found in bottom of the returned error. To determine a more precise error message, execute the native extension binary directly. Normally the binary lives in the `bin/plugin` in the native extension direcotry. | |||
There was a problem hiding this comment.
suggestion: verb tense and reordering
Suggested change
| The [`go-plugin`](https://github.com/hashicorp/go-plugin) library does not surface errors to stencil. Instead, it will raise the generic message `failed to create connection to extension: Unrecognized remote plugin message`. The binary path could be found in bottom of the returned error. To determine a more precise error message, execute the native extension binary directly. Normally the binary lives in the `bin/plugin` in the native extension direcotry. | |
| The [`go-plugin`](https://github.com/hashicorp/go-plugin) library does not surface errors to stencil. Instead, it will raise the generic message `failed to create connection to extension: Unrecognized remote plugin message`. To determine a more precise error message, execute the native extension binary directly. The binary path can usually be found in bottom of the returned error. If not, the binary lives in the `bin/plugin` subdirectory of the native extension folder. |
|
🎉 This PR is included in version 1.37.2-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.37.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read CONTRIBUTING.md for additional information on contributing to this repository!
What this PR does / why we need it
Address the comment for merged PR. (#302 (comment))
Jira ID
[XX-XX]
Notes for your reviewers