Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README, git clone with parallel jobs #686

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

README, git clone with parallel jobs #686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ directory ``~/pelican-themes``, but yours could be different. Clone the

.. code-block:: sh

git clone --recursive https://github.com/getpelican/pelican-themes ~/pelican-themes
git clone --jobs 8 --recursive https://github.com/getpelican/pelican-themes ~/pelican-themes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole document has a bit of a "POSIX-or-die" slant that might not be the most helpful, but in keeping with that motif, wouldn't it be more adaptive to set --jobs "$(nproc)" here rather than supply a fixed value when we have no a priori knowledge about their environment?

As far as the POSIX-or-die part, I think that can be resolved pretty well by prepending bash -c to what's already there (since we can reasonably assume that however someone got Git installed on Windows it includes a Bash interpreter in PATH) and replacing ~ with $HOME in the target path argument (PowerShell Core aliases that to $Env:UserProfile I'm pretty sure, no idea about CMD.exe though), but my familiarly with both the Windows Command Interpreter and Windows PowerShell makes me wish someone with more experience in that domain would spot check my thinking on that part.


Now you should have your ``pelican-themes`` repository stored at
``~/pelican-themes/``.
Expand Down