Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update env-vars-settings.md: Add REDASH_CSV_WRITER_ENCODING to change the encoding of the CSV file #679

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kaibadash
Copy link

Update env-vars-settings.md: Add REDASH_CSV_WRITER_ENCODING to change the encoding of the CSV file.

see: getredash/redash#5826

@justinclift
Copy link
Member

Oops. I didn't realise the restyled check failed.

@justinclift
Copy link
Member

@kaibadash Would you be ok to apply the restyled suggested change, and add the result to this PR?

https://restyled.io/gh/getredash/repos/website/jobs/3428115

@kaibadash
Copy link
Author

@justinclift I fixed it. Thank you for your review.

@justinclift
Copy link
Member

@kaibadash Thanks, it's passing now.

We can merge this PR once the tests for it's matching PR in the Redash repo (getredash/redash#5826) are passing. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants