-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Session replay transformed view masking #4529
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6e342ac | 1202.98 ms | 1228.74 ms | 25.76 ms |
f74904f | 1229.02 ms | 1244.91 ms | 15.89 ms |
160a2a7 | 1219.29 ms | 1240.96 ms | 21.67 ms |
adca747 | 1199.37 ms | 1215.49 ms | 16.12 ms |
d9fff0f | 1205.09 ms | 1247.40 ms | 42.31 ms |
e89dc54 | 1207.86 ms | 1218.27 ms | 10.41 ms |
b0e218b | 1218.14 ms | 1230.33 ms | 12.19 ms |
0559a8f | 1212.37 ms | 1232.12 ms | 19.76 ms |
a0cc9d6 | 1235.22 ms | 1248.37 ms | 13.14 ms |
24e0744 | 1239.15 ms | 1252.39 ms | 13.24 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6e342ac | 20.76 KiB | 436.66 KiB | 415.90 KiB |
f74904f | 21.58 KiB | 418.71 KiB | 397.12 KiB |
160a2a7 | 21.58 KiB | 614.86 KiB | 593.28 KiB |
adca747 | 20.76 KiB | 401.36 KiB | 380.60 KiB |
d9fff0f | 22.85 KiB | 401.65 KiB | 378.81 KiB |
e89dc54 | 22.85 KiB | 412.60 KiB | 389.75 KiB |
b0e218b | 21.58 KiB | 638.28 KiB | 616.70 KiB |
0559a8f | 21.58 KiB | 419.81 KiB | 398.22 KiB |
a0cc9d6 | 21.58 KiB | 706.47 KiB | 684.88 KiB |
24e0744 | 21.58 KiB | 709.06 KiB | 687.48 KiB |
Previous results on branch: fix/masking
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
caade2a | 1223.21 ms | 1245.27 ms | 22.06 ms |
65d2b7d | 1223.29 ms | 1238.06 ms | 14.77 ms |
3aa67df | 1213.92 ms | 1240.45 ms | 26.53 ms |
2937a54 | 1234.49 ms | 1250.29 ms | 15.80 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
caade2a | 22.30 KiB | 749.69 KiB | 727.38 KiB |
65d2b7d | 22.30 KiB | 730.75 KiB | 708.45 KiB |
3aa67df | 22.30 KiB | 730.74 KiB | 708.44 KiB |
2937a54 | 22.30 KiB | 731.06 KiB | 708.76 KiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4529 +/- ##
=============================================
+ Coverage 90.900% 90.916% +0.015%
=============================================
Files 616 616
Lines 70502 70568 +66
Branches 25111 25065 -46
=============================================
+ Hits 64087 64158 +71
+ Misses 6322 6317 -5
Partials 93 93
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Co-authored-by: Philipp Hofmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Fixing some masking regression and added test to track it.
💡 Motivation and Context
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps