Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Session replay opacity animation masking #4532

Merged
merged 7 commits into from
Nov 15, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

Animated opacity was not being properly masked

💚 How did you test it?

Sample and Unit test

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

github-actions bot commented Nov 13, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.76 ms 1230.67 ms 12.92 ms
Size 22.30 KiB 730.76 KiB 708.46 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9fa25c2 1211.88 ms 1228.36 ms 16.48 ms
86660d6 1325.72 ms 1365.02 ms 39.30 ms
4d3df92 1218.27 ms 1248.30 ms 30.03 ms
2d35ccb 1220.40 ms 1239.16 ms 18.77 ms
742d4b6 1230.41 ms 1247.23 ms 16.83 ms
2124551 1246.10 ms 1254.84 ms 8.74 ms
ecd9ecd 1241.28 ms 1260.35 ms 19.07 ms
0d32275 1230.96 ms 1237.90 ms 6.94 ms
0204c72 1230.35 ms 1242.04 ms 11.69 ms
340fb46 1224.60 ms 1239.27 ms 14.67 ms

App size

Revision Plain With Sentry Diff
9fa25c2 22.85 KiB 407.44 KiB 384.59 KiB
86660d6 21.58 KiB 682.92 KiB 661.34 KiB
4d3df92 22.85 KiB 413.45 KiB 390.60 KiB
2d35ccb 21.58 KiB 705.96 KiB 684.38 KiB
742d4b6 21.58 KiB 546.20 KiB 524.62 KiB
2124551 22.85 KiB 411.69 KiB 388.84 KiB
ecd9ecd 20.76 KiB 420.23 KiB 399.47 KiB
0d32275 22.84 KiB 403.14 KiB 380.29 KiB
0204c72 21.58 KiB 540.04 KiB 518.46 KiB
340fb46 21.58 KiB 418.78 KiB 397.20 KiB

Previous results on branch: fix/opacity-animation-masking

Startup times

Revision Plain With Sentry Diff
a8ee352 1229.30 ms 1250.04 ms 20.74 ms
ce58ae6 1233.63 ms 1251.85 ms 18.22 ms

App size

Revision Plain With Sentry Diff
a8ee352 22.30 KiB 730.73 KiB 708.43 KiB
ce58ae6 22.30 KiB 730.76 KiB 708.45 KiB

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.589%. Comparing base (01bdff8) to head (f7faf5e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4532       +/-   ##
=============================================
+ Coverage   91.533%   91.589%   +0.055%     
=============================================
  Files          614       615        +1     
  Lines        69747     69934      +187     
  Branches     24880     25058      +178     
=============================================
+ Hits         63842     64052      +210     
+ Misses        5812      5788       -24     
- Partials        93        94        +1     
Files with missing lines Coverage Δ
Sources/Swift/Tools/UIRedactBuilder.swift 93.721% <100.000%> (ø)
Tests/SentryTests/UIRedactBuilderTests.swift 100.000% <100.000%> (ø)

... and 36 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01bdff8...f7faf5e. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some questions about the tests.

Tests/SentryTests/UIRedactBuilderTests.swift Show resolved Hide resolved
Tests/SentryTests/UIRedactBuilderTests.swift Show resolved Hide resolved
@brustolin brustolin enabled auto-merge (squash) November 15, 2024 08:53
@brustolin brustolin merged commit f8eb5a7 into main Nov 15, 2024
64 of 65 checks passed
@brustolin brustolin deleted the fix/opacity-animation-masking branch November 15, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants