Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Masking for fast animations #4574

Merged
merged 5 commits into from
Nov 28, 2024
Merged

fix: Masking for fast animations #4574

merged 5 commits into from
Nov 28, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

Speeding up mask calculation

💚 How did you test it?

Samples Only

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

github-actions bot commented Nov 26, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.02 ms 1239.67 ms 14.65 ms
Size 22.30 KiB 749.83 KiB 727.53 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4afae53 1217.65 ms 1229.27 ms 11.62 ms
07bfb56 1234.33 ms 1259.12 ms 24.80 ms
efb2222 1258.22 ms 1276.78 ms 18.56 ms
a6c634b 1235.86 ms 1250.53 ms 14.67 ms
626b91b 1231.67 ms 1247.13 ms 15.46 ms
98cca71 1230.43 ms 1252.36 ms 21.93 ms
ae1fe61 1231.81 ms 1252.76 ms 20.95 ms
e1eed6b 1259.08 ms 1270.57 ms 11.49 ms
087a3b3 1231.73 ms 1251.13 ms 19.39 ms
d9308fd 1214.89 ms 1244.37 ms 29.47 ms

App size

Revision Plain With Sentry Diff
4afae53 22.84 KiB 402.08 KiB 379.24 KiB
07bfb56 21.90 KiB 726.18 KiB 704.28 KiB
efb2222 20.76 KiB 424.45 KiB 403.69 KiB
a6c634b 20.76 KiB 393.37 KiB 372.61 KiB
626b91b 21.58 KiB 546.20 KiB 524.61 KiB
98cca71 22.85 KiB 411.14 KiB 388.29 KiB
ae1fe61 21.58 KiB 698.91 KiB 677.33 KiB
e1eed6b 20.76 KiB 432.17 KiB 411.41 KiB
087a3b3 21.58 KiB 707.42 KiB 685.84 KiB
d9308fd 21.58 KiB 612.82 KiB 591.24 KiB

Previous results on branch: fix/speedup-masking

Startup times

Revision Plain With Sentry Diff
1c73fda 1224.43 ms 1233.47 ms 9.04 ms

App size

Revision Plain With Sentry Diff
1c73fda 22.30 KiB 749.57 KiB 727.27 KiB

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.993%. Comparing base (f673937) to head (e3d4305).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4574       +/-   ##
=============================================
+ Coverage   90.899%   90.993%   +0.093%     
=============================================
  Files          616       617        +1     
  Lines        70579     70824      +245     
  Branches     25077     25292      +215     
=============================================
+ Hits         64156     64445      +289     
+ Misses        6331      6286       -45     
- Partials        92        93        +1     
Files with missing lines Coverage Δ
Sources/Swift/Tools/SentryViewPhotographer.swift 93.750% <100.000%> (ø)
Sources/Swift/Tools/UIRedactBuilder.swift 93.777% <100.000%> (-0.055%) ⬇️

... and 46 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f673937...e3d4305. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if we really can't write a test for this.

Sources/Swift/Tools/UIRedactBuilder.swift Outdated Show resolved Hide resolved
@brustolin brustolin merged commit ed64658 into main Nov 28, 2024
66 checks passed
@brustolin brustolin deleted the fix/speedup-masking branch November 28, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants