Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Session replay Log typo #4586

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Chore: Session replay Log typo #4586

merged 1 commit into from
Dec 2, 2024

Conversation

brustolin
Copy link
Contributor

Fixing a typo.

#skip-changelog

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.001%. Comparing base (bee3e88) to head (2fb2910).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4586       +/-   ##
=============================================
- Coverage   91.004%   91.001%   -0.004%     
=============================================
  Files          617       617               
  Lines        70883     70878        -5     
  Branches     25322     25304       -18     
=============================================
- Hits         64507     64500        -7     
  Misses        6284      6284               
- Partials        92        94        +2     
Files with missing lines Coverage Δ
Sources/Sentry/SentrySessionReplayIntegration.m 86.432% <100.000%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee3e88...2fb2910. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.49 ms 1258.38 ms 20.89 ms
Size 22.30 KiB 749.95 KiB 727.65 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8e4bc70 1229.18 ms 1240.86 ms 11.67 ms
fff4a70 1224.57 ms 1239.06 ms 14.49 ms
cf97209 1234.06 ms 1251.49 ms 17.43 ms
deeb22c 1233.90 ms 1250.19 ms 16.29 ms
62f06fc 1213.91 ms 1238.08 ms 24.17 ms
9fa5d27 1219.86 ms 1221.71 ms 1.85 ms
8c50edb 1212.98 ms 1233.72 ms 20.74 ms
4aea556 1222.94 ms 1248.02 ms 25.08 ms
ea73af6 1230.96 ms 1244.98 ms 14.02 ms
c1ca4cb 1228.71 ms 1246.23 ms 17.53 ms

App size

Revision Plain With Sentry Diff
8e4bc70 21.58 KiB 625.90 KiB 604.32 KiB
fff4a70 21.58 KiB 707.28 KiB 685.70 KiB
cf97209 21.58 KiB 632.16 KiB 610.58 KiB
deeb22c 21.58 KiB 612.11 KiB 590.53 KiB
62f06fc 21.58 KiB 671.30 KiB 649.72 KiB
9fa5d27 20.76 KiB 393.37 KiB 372.61 KiB
8c50edb 20.76 KiB 432.31 KiB 411.55 KiB
4aea556 22.85 KiB 411.66 KiB 388.81 KiB
ea73af6 20.76 KiB 425.75 KiB 404.99 KiB
c1ca4cb 22.30 KiB 747.52 KiB 725.22 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@brustolin brustolin merged commit cabe995 into main Dec 2, 2024
65 of 66 checks passed
@brustolin brustolin deleted the chore/log-typo branch December 2, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants