Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr: Track usage of persistingTracesWhenCrashing #4587

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

philipphofmann
Copy link
Member

📜 Description

Add enablePersistingTracesWhenCrashing to the list of enabled features when the option enablePersistingTracesWhenCrashing is enabled.

💡 Motivation and Context

We want to know how many people use enablePersistingTracesWhenCrashing. Follow up on #4504.

💚 How did you test it?

Unit test.

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Add enablePersistingTracesWhenCrashing to the list of enabled features
when the option enablePersistingTracesWhenCrashing is enabled.
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.964%. Comparing base (cabe995) to head (258ac2d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4587       +/-   ##
=============================================
- Coverage   91.005%   90.964%   -0.041%     
=============================================
  Files          617       616        -1     
  Lines        70877     70734      -143     
  Branches     25302     25140      -162     
=============================================
- Hits         64502     64343      -159     
- Misses        6282      6299       +17     
+ Partials        93        92        -1     
Files with missing lines Coverage Δ
...es/Swift/Helper/SentryEnabledFeaturesBuilder.swift 100.000% <100.000%> (ø)
...sts/Helper/SentryEnabledFeaturesBuilderTests.swift 100.000% <100.000%> (ø)

... and 35 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cabe995...258ac2d. Read the comment docs.

Copy link

github-actions bot commented Dec 2, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.24 ms 1250.62 ms 22.37 ms
Size 22.30 KiB 750.02 KiB 727.72 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8e4bc70 1229.18 ms 1240.86 ms 11.67 ms
fff4a70 1224.57 ms 1239.06 ms 14.49 ms
cf97209 1234.06 ms 1251.49 ms 17.43 ms
deeb22c 1233.90 ms 1250.19 ms 16.29 ms
62f06fc 1213.91 ms 1238.08 ms 24.17 ms
9fa5d27 1219.86 ms 1221.71 ms 1.85 ms
8c50edb 1212.98 ms 1233.72 ms 20.74 ms
4aea556 1222.94 ms 1248.02 ms 25.08 ms
ea73af6 1230.96 ms 1244.98 ms 14.02 ms
c1ca4cb 1228.71 ms 1246.23 ms 17.53 ms

App size

Revision Plain With Sentry Diff
8e4bc70 21.58 KiB 625.90 KiB 604.32 KiB
fff4a70 21.58 KiB 707.28 KiB 685.70 KiB
cf97209 21.58 KiB 632.16 KiB 610.58 KiB
deeb22c 21.58 KiB 612.11 KiB 590.53 KiB
62f06fc 21.58 KiB 671.30 KiB 649.72 KiB
9fa5d27 20.76 KiB 393.37 KiB 372.61 KiB
8c50edb 20.76 KiB 432.31 KiB 411.55 KiB
4aea556 22.85 KiB 411.66 KiB 388.81 KiB
ea73af6 20.76 KiB 425.75 KiB 404.99 KiB
c1ca4cb 22.30 KiB 747.52 KiB 725.22 KiB

@philipphofmann philipphofmann merged commit fbcf858 into main Dec 2, 2024
57 of 62 checks passed
@philipphofmann philipphofmann deleted the impr/track-persisting-traces-when-crashing branch December 2, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants