Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POTEL 58 - Extract OpenTelemetry URL_PATH span attribute into description #3933

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

adinauer
Copy link
Member

📜 Description

Extract OpenTelemetry URL_PATH span attribute into description if other attributes aren't available.

💡 Motivation and Context

Fixes #3932

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 27, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against eb26608

Copy link
Contributor

github-actions bot commented Nov 27, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 430.04 ms 462.02 ms 31.98 ms
Size 1.65 MiB 2.31 MiB 676.03 KiB

Previous results on branch: feat/extract-url-path-into-description

Startup times

Revision Plain With Sentry Diff
14ed750 437.16 ms 503.33 ms 66.17 ms

App size

Revision Plain With Sentry Diff
14ed750 1.65 MiB 2.31 MiB 676.03 KiB

adinauer and others added 2 commits November 27, 2024 10:21
…o/sentry/opentelemetry/SpanDescriptionExtractor.java

Co-authored-by: Stefano <[email protected]>
@adinauer adinauer merged commit 7c61b46 into 8.x.x Nov 27, 2024
35 checks passed
@adinauer adinauer deleted the feat/extract-url-path-into-description branch November 27, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants