Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .NET 9 - Sentry SDK 5.0.0-alpha.1 #203

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Use .NET 9 - Sentry SDK 5.0.0-alpha.1 #203

wants to merge 7 commits into from

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Oct 22, 2024

@bruno-garcia
Copy link
Member Author

Possibly blocked by:

Xamarin.UITest doesn't work with an app built with .NET 9

1) Error : SymbolCollector.Android.UITests.Tests.CollectSymbols
System.Exception : No .NET assemblies were found in the application. Please disable Fast Deployment in the Visual Studio project property pages or edit the project file in a text editor and set the 'EmbedAssembliesIntoApk' MSBuild property to 'true'.
  at Xamarin.UITest.Shared.Android.ApkFile.EnsureDotNetAssembliesAreBundled () [0x00008] in <b9b62bebca2b4a9e85e5edd581b4def3>:0 
  at Xamarin.UITest.Android.AndroidAppInitializer.PrepareApkFiles (Xamarin.UITest.Configuration.IAndroidAppConfiguration appConfiguration, Xamarin.UITest.Shared.Artifacts.ArtifactFolder artifactFolder) [0x0016a] in <c9af78a12b8d433882fce1ed49df24c2>:0 
  at Xamarin.UITest.Android.AndroidApp..ctor (Xamarin.UITest.Configuration.IAndroidAppConfiguration appConfiguration, Xamarin.UITest.Shared.Execution.IExecutor executor) [0x00143] in <c9af78a12b8d433882fce1ed49df24c2>:0 
  at Xamarin.UITest.Android.AndroidApp..ctor (Xamarin.UITest.Configuration.IAndroidAppConfiguration appConfiguration) [0x00000] in <c9af78a12b8d433882fce1ed49df24c2>:0 
  at Xamarin.UITest.Configuration.AndroidAppConfigurator.StartApp (Xamarin.UITest.Configuration.AppDataMode appDataMode) [0x00017] in <c9af78a12b8d433882fce1ed49df24c2>:0 
  at SymbolCollector.Android.UITests.Tests.BeforeEachTest () [0x0002f] in <2ba557932dfd4d2f9f65d4a8e949dfd1>:0 
  at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
  at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in <e068e2227ab74c1bb3d724ebaab0e3ff>:0 

But EmbedAssembliesIntoApk didn't help.

@bruno-garcia bruno-garcia marked this pull request as ready for review December 3, 2024 01:27
@@ -80,6 +80,10 @@ private static IHostBuilder CreateHostBuilder(string[] args) =>
o.AddExceptionFilterForType<OperationCanceledException>();
o.MinimumBreadcrumbLevel = LogLevel.Debug;
o.CaptureFailedRequests = true;

// https://github.com/getsentry/symbol-collector/issues/205
// o.CaptureBlockingCalls = true;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should get a lauchdarkly account and test this out with it (+ dogfood our feature flag integration)

@bruno-garcia bruno-garcia changed the title net9 Use .NET 9 - Sentry SDK 5.0.0-alpha.1 Dec 6, 2024
.Or<SocketTimeoutException>()
.SentryPolicy(s));
services.AddHttpClient<ISymbolClient, SymbolClient>();
// .ConfigurePrimaryHttpMessageHandler<AndroidMessageHandler>()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised it works (CI does) without this @jamescrosswell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants