Implement get_resource_reader method in rewrite's loader #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiadOz
reviewed
May 29, 2024
dessert/rewrite.py
Outdated
Comment on lines
214
to
220
| def get_resource_reader(self, name: str) -> importlib.abc.TraversableResources: | ||
| from types import SimpleNamespace | ||
| if sys.version_info < (3, 11): | ||
| from importlib.readers import FileReader | ||
| else: | ||
| from importlib.resources.readers import FileReader | ||
| return FileReader(SimpleNamespace(path=self._rewritten_names[name])) |
There was a problem hiding this comment.
Is there a reason you didn't use the latest code from pytest:
if sys.version_info >= (3, 10):
if sys.version_info >= (3, 12):
from importlib.resources.abc import TraversableResources
else:
from importlib.abc import TraversableResources
def get_resource_reader(self, name: str) -> TraversableResources:
if sys.version_info < (3, 11):
from importlib.readers import FileReader
else:
from importlib.resources.readers import FileReader
return FileReader(types.SimpleNamespace(path=self._rewritten_names[name]))https://github.com/pytest-dev/pytest/blob/main/src/_pytest/assertion/rewrite.py
|
@giladmoav Can you try to write a test for it? |
giladmoav
force-pushed
the
fix-loader-issue
branch
2 times, most recently
from
11f0e99 to
09ed945
Compare
giladmoav
force-pushed
the
fix-loader-issue
branch
from
09ed945 to
5ae1c5d
Compare
|
@giladmoav looks good |
|
@ayalash Hi, any progress on that? |
|
Thanks @giladmoav & @LiadOz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue in #25 is that AssertionRewritingHook doesn't implement get_resource_reader (from PEP302), I implemented the method like in pytest