Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common/Scripts: return 1 instead of exit 1 on err in helper.sh #1011

Merged
merged 1 commit into from
Dec 14, 2023
Merged

common/Scripts: return 1 instead of exit 1 on err in helper.sh #1011

merged 1 commit into from
Dec 14, 2023

Conversation

joebonrichie
Copy link
Contributor

Summary

So it doesn't exit the shell.

Test Plan

gotopkg grub (grub2) doesn't exit the shell anymore

Checklist

  • Package was built and tested against unstable n/a

ermo
ermo approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ermo ermo merged commit c3c967f into main Dec 14, 2023
2 checks passed
@ermo ermo deleted the where-did-my-shell-go branch December 14, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermo ermo ermo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Solus
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joebonrichie @ermo