Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helpers*sh: Update/add cpesearch for bash/fish/zsh #1481

Merged
merged 1 commit into from
Feb 1, 2024
Merged

helpers*sh: Update/add cpesearch for bash/fish/zsh #1481

merged 1 commit into from
Feb 1, 2024

Conversation

ermo
Copy link
Contributor

@ermo ermo commented Jan 31, 2024

Now supports showing usage if '-h' and '--help' are supplied as arguments

@ermo ermo requested a review from davidjharder January 31, 2024 20:29
@ermo
helpers*sh: Update/add cpesearch for bash/fish/zsh
f501790 
Now supports showing usage if '-h' and '--help' are supplied as arguments

Signed-off-by: Rune Morling <[email protected]>
@ermo ermo force-pushed the cpesearch-updates branch from 50364c4 to f501790 Compare January 31, 2024 20:31
@ermo ermo mentioned this pull request Jan 31, 2024
Open
5 tasks
davidjharder
davidjharder approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@davidjharder davidjharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I need to make a note somewhere of curl and jq as soft packaging dependencies

Tested all 3, they fail somewhat gracefully when missing jq, all work as expected

@ermo ermo merged commit 4227e77 into main Feb 1, 2024
2 checks passed
@ReillyBrogan ReillyBrogan deleted the cpesearch-updates branch February 3, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjharder davidjharder davidjharder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Solus
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ermo @davidjharder