ci: Check shell scripts in common with shellcheck #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add shellcheck action to the GitHub workflow to reduce the amount of bugs in shell scripts. Currently failing scripts (and one zsh script) have been excluded. These can be removed from the ignored scripts when they have been fixed. Resolves #968
ermo
requested changes
Dec 4, 2023
ermo
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Better get this in. Then @joebonrichie can document the helpers.sh in a separate commit. >_>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add shellcheck action to the GitHub workflow to reduce the amount of bugs in shell scripts.
Currently failing scripts (and one zsh script) have been excluded.
These can be removed from the ignored scripts when they have been fixed.
Resolves #968
Test Plan
This PR!
Checklist