-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
age-plugin support #1335
age-plugin support #1335
Conversation
@@ -5,7 +5,7 @@ go 1.19 | |||
require ( | |||
cloud.google.com/go/kms v1.15.3 | |||
cloud.google.com/go/storage v1.33.0 | |||
filippo.io/age v1.1.1 | |||
filippo.io/age v1.1.2-0.20230920124100-101cc8676386 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess a new age release would be still a blocker for this, but review could already happen before that, so by the time we have an age update, this can be merged.
You have to go through this process before anyone looks at your commit probably: https://github.com/getsops/sops/pull/1335/checks?check_run_id=18181524828 |
Check again if I did it correctly |
Looks better now. |
Signed-off-by: Jörg Thalheim <[email protected]>
Hi. But then i want do something on linux:
age-plugin-se - is only for macos. Not possible to install on linux! Soo this error blocks me from adding the newkey (standard/classic age key) from Linux. |
Honestly, I am kinda interested in rops more right now and I think I will implement or help implement age-plugin support for it. Don't expect me to continue working on this PR, I don't know Go. |
@Kranzes same issue can happen there :) |
Your problem stems from the Go code written as part of this PR, it is not inherent to age plugin support for sops/rops, right? |
Age recently exposed their plugins API as public which allows using it to add Age plugins support to Sops. With these changes which I have no written and don't understand I was able to get age plugins working in Sops. I'd like if someone that knows Go and the codebase continues these changes, as from what I understood a lot of them are just copied over from age itself (?).