fix: permissions for shop #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| export const Route = createFileRoute('/_auth/gameserver/$gameServerId')({ | ||
| beforeLoad: async ({ context }) => { | ||
| const session = await context.auth.getSession(); | ||
| if (!hasPermission(session, ['READ_GAMESERVERS'])) { |
There was a problem hiding this comment.
not that it matters really, but the hasPermission is typed based on PERMISSIONS from @takaro/apiclient, so it's not really needed to import
emielvanseveren
approved these changes
Jul 20, 2024
No, is deleted as we discussed. Every user can now read basic info about gameservers inside a domain |
|
can we merge this? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.