Module versions

[niekcandaele]

No description provided.

Copilot reviewed 64 out of 79 changed files in this pull request and generated 1 suggestion.

Files not reviewed (15)

• packages/app-api/package.json: Language not supported
• packages/app-api/src/domainInit.ts: Evaluated as low risk
• packages/app-api/src/controllers/tests/GameServerController.integration.test.ts: Evaluated as low risk
• packages/app-api/src/controllers/GameServerController.ts: Evaluated as low risk
• packages/app-api/src/controllers/tests/modifyBuiltinModules.integration.test.ts: Evaluated as low risk
• packages/app-api/src/db/gameserver.ts: Evaluated as low risk
• packages/app-api/src/controllers/tests/CronJobController.integration.test.ts: Evaluated as low risk
• packages/app-api/src/controllers/tests/ModuleConfig.integration.test.ts: Evaluated as low risk
• packages/app-api/src/controllers/tests/CommandController.integration.test.ts: Evaluated as low risk
• packages/app-api/src/db/role.ts: Evaluated as low risk
• packages/app-api/src/controllers/tests/ModuleAssignments.integration.test.ts: Evaluated as low risk
• deploy/compose/docker-compose.yml: Evaluated as low risk
• packages/app-api/src/controllers/tests/HookController.integration.test.ts: Evaluated as low risk
• packages/app-api/src/controllers/Module/modules.ts: Evaluated as low risk
• packages/app-api/src/controllers/tests/ModuleController.integration.test.ts: Evaluated as low risk

Comments skipped due to low confidence (5)

packages/app-api/src/controllers/Module/installations.ts:64

• [nitpick] The method name getInstalledModules is misleading. It should be renamed to searchModuleInstallations to better reflect its functionality.

async getInstalledModules(@Req() req: AuthenticatedRequest, @Res() res: Response, @Body() query: ModuleInstallationSearchInputDTO) {

packages/app-api/src/controllers/Module/versions.ts:157

• The description field in the BuiltinModule constructor is not always present in the version object.

const output = new BuiltinModule(mod.name, version.description, version.tag, version.configSchema, version.uiSchema);

packages/app-api/src/controllers/Module/versions.ts:136

• The params parameter is not used in the tagVersion function.

async tagVersion(@Req() req: AuthenticatedRequest, @Params() params: ParamId, @Body() data: ModuleVersionCreateAPIDTO) {

packages/app-api/src/controllers/Module/versions.ts:136

• Ensure that the tag field in ModuleVersionCreateAPIDTO is validated properly.

async tagVersion(@Req() req: AuthenticatedRequest, @Params() params: ParamId, @Body() data: ModuleVersionCreateAPIDTO) {

packages/app-api/src/db/module.ts:455

• Ensure that InstallModuleDTO is correctly validated before being used.

async installModule(installDto: InstallModuleDTO) {