Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map API support #1842

Merged
merged 2 commits into from
Dec 15, 2024
Merged

Add map API support #1842

merged 2 commits into from
Dec 15, 2024

Conversation

niekcandaele
Copy link
Collaborator

No description provided.

@niekcandaele niekcandaele added the enhancement New feature or request label Dec 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • packages/lib-gameserver/src/gameservers/7d2d/sdtdAPIClient.ts: Evaluated as low risk
  • packages/lib-gameserver/src/gameservers/mock/index.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)

packages/app-api/src/service/GameServerService.ts:600

  • Ensure that the behavior when getMapTile throws an error is covered by tests.
return gameInstance.getMapTile(x, y, z);

packages/lib-gameserver/src/gameservers/rust/index.ts:254

  • The error message 'Not implemented' is not informative. Consider providing more context, such as 'Map tile retrieval is not implemented for Rust game server'.
throw new Error('Not implemented');
@niekcandaele niekcandaele added this pull request to the merge queue Dec 15, 2024
Merged via the queue into development with commit fc99f56 Dec 15, 2024
17 checks passed
@niekcandaele niekcandaele deleted the map-api branch December 15, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant