Return BadRequestError if user_id is empty (#261)

getzep · Nov 4, 2023 · 89b5f46 · 89b5f46
1 parent 88d7882
commit 89b5f46
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/pkg/store/postgres/userstore.go b/pkg/store/postgres/userstore.go
@@ -29,6 +29,9 @@ func (dao *UserStoreDAO) Create(
 	ctx context.Context,
 	user *models.CreateUserRequest,
 ) (*models.User, error) {
+	if user.UserID == "" {
+		return nil, models.NewBadRequestError("UserID cannot be empty")
+	}
 	userDB := &UserSchema{
 		UserID:    user.UserID,
 		Email:     user.Email,

diff --git a/pkg/store/postgres/userstore_test.go b/pkg/store/postgres/userstore_test.go
@@ -40,6 +40,15 @@ func TestUserStoreDAO(t *testing.T) {
 		assert.NotEmpty(t, createdUser.ID)
 	})
 
+	// Test Create
+	t.Run("Create with no user_id", func(t *testing.T) {
+		userNoId := &models.CreateUserRequest{
+			UserID: "",
+		}
+		_, err := userStore.Create(ctx, userNoId)
+		assert.ErrorIs(t, err, models.ErrBadRequest)
+	})
+
 	// Test Get
 	t.Run("Get", func(t *testing.T) {
 		retrievedUser, err := userStore.Get(ctx, user.UserID)