feat(postgres): Add URL escaping to database connection string #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add url.QueryEscape() to properly handle special characters in PostgreSQL connection parameters. This prevents potential connection issues and improves security when credentials contain special characters. Changes: - Escape username with url.QueryEscape() - Escape password with url.QueryEscape() - Escape hostname with url.QueryEscape() - Escape database name with url.QueryEscape() Example special characters handled: - @ in usernames (e.g., [email protected]) - Special chars in passwords (e.g., *, (, ), @) - Special chars in database names This change ensures the DSN string is properly formatted regardless of the characters present in the connection parameters. Related to PostgreSQL connection string format: postgres://username:password@hostname:port/database
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 4bf628d in 47 seconds
More details
- Looked at
38lines of code in1files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/lib/config/config.go:8
- Draft comment:
Spelling and grammar issues in comments: - Line 8: "this" should be capitalized to "This".
- Line 19: "sane" could be replaced with "reasonable" for better clarity.
- Line 19: "config options. when" should be "config options. When".
- Line 83: "there" should be capitalized to "There".
- Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_KQa6YOckpS2f2aSz
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Remove url.QueryEscape for Host Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
|
@danielchalef Is anyone around to review this at some point? |
alexbricepalo
temporarily deployed
to
build-test
GitHub Actions
Inactive
paul-paliychuk
approved these changes
Nov 28, 2024
|
@alexbricepalo Thanks for your contribution |
|
Published as part of v1.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add url.QueryEscape() to properly handle special characters in PostgreSQL connection parameters. This prevents potential connection issues and improves security when credentials contain special characters.
Changes:
Example special characters handled:
This change ensures the DSN string is properly formatted regardless of the characters present in the connection parameters.
Related to PostgreSQL connection string format:
postgres://username:password@hostname:port/database
Important
Add URL escaping to PostgreSQL connection string in
config.goto handle special characters in connection parameters.url.QueryEscape()to escape special characters in PostgreSQL connection parameters inDSN()inconfig.go.This description was created by
for 4bf628d. It will automatically update as commits are pushed.