FR: server: Pre-fill textarea and auto-generate based on query parameters #11150
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow pre-filling the msg-input textarea with a message supplied via a query parameter ?m=... and auto-focus the textarea. Example: http://localhost:8080/?m=What%20is%20your%20name? Alternatively, allow pre-filling the msg-input textarea via a query parameter ?q=... and automatically start generating a response, e.g.: http://localhost:8080/?q=What%20is%20your%20name? * main.js: fill inputMsg from ?q or ?m * main.js: once the App is mounted, click(msg-send) on ?q * main.js: once the App is mounted, focus(msg-input) on ?m * examples/server/webui/index.html: assign id="msg-send" to the "Send" button Signed-off-by: Tim Janik <[email protected]>
Update via: cd ../llama.cpp/./examples/server/webui && npm i && npm run build Signed-off-by: Tim Janik <[email protected]>
ngxson
requested changes
Jan 9, 2025
| @@ -153,7 +153,7 @@ <h2 class="font-bold ml-4">Conversations</h2> | |||
| :disabled="isGenerating" | |||
| id="msg-input" | |||
| ></textarea> | |||
| <button v-if="!isGenerating" class="btn btn-primary ml-2" @click="sendMessage" :disabled="inputMsg.length === 0">Send</button> | |||
| <button v-if="!isGenerating" class="btn btn-primary ml-2" @click="sendMessage" :disabled="inputMsg.length === 0" id="msg-send">Send</button> | |||
There was a problem hiding this comment.
This button calls sendMessage() function as stated in @click. You should call the underlay function instead of assigning an ID for it.
| @@ -1,5 +1,6 @@ | |||
| import './styles.scss'; | |||
| import { createApp, defineComponent, shallowRef, computed, h } from 'vue/dist/vue.esm-bundler.js'; | |||
| import { nextTick } from 'vue/dist/vue.esm-bundler.js'; | |||
There was a problem hiding this comment.
Why can't we add this to the line above it?
ngxson
reviewed
Jan 9, 2025
| @@ -313,6 +314,9 @@ async function* sendSSEPostRequest(url, fetchOptions) { | |||
| } | |||
| }; | |||
|
|
|||
| const usp = new URLSearchParams (window.location.search); | |||
| const initial_query = usp.get ('q'), initial_msg = initial_query || usp.get ('m') || ''; | |||
There was a problem hiding this comment.
Pay attention to the coding style too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR proposes changes to the server Web UI to add the ability to pre-fill the textarea (
id=msg-input) with a message supplied via a query parameter (?m=...) and auto-focus the textarea. Additionally, this allows pre-filling the textarea via a query parameter (?q=...) and automatically start generating a response.Example Usage:
Pre-fill the textarea and focus:
http://localhost:8080/?m=Translate%20into%20Klingon%3A%20
Pre-fill the textarea and automatically start generating a response:
http://localhost:8080/?q=What%20is%20your%20name%3F
Proposed Changes:
examples/server/webui/index.htmlto assignid=msg-inputto the "Send" button.examples/server/webui/src/main.jsto:inputMsgfrom?qor?m.?qis present.msg-inputtextarea on page load if?mis present.Use Cases:
By using browser bookmarks with query strings, several interesting model queries can be pre-populate, e.g.
?m=Summarize:,?m=Translate%20to%20French:And it allows quick testing and demonstrations:
?q=Howto%20build%20a%20Website