Fix the feature keyword issue #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SagarGi
force-pushed
the
OnlyOneFeatureIssue
branch
3 times, most recently
from
e5ca064
to
6b981e9
Compare
saw-jan
requested changes
Jul 1, 2022
There was a problem hiding this comment.
fixing the regex would be the way to go
gherlint-vscode/server/src/regex.js
Line 3 in d10e18e
will try to fix it with regex. |
SagarGi
force-pushed
the
OnlyOneFeatureIssue
branch
from
6b981e9
to
621c124
Compare
SagarGi
changed the title
saw-jan
reviewed
Jul 4, 2022
| @@ -1,6 +1,6 @@ | |||
| module.exports = { | |||
| globalMatch: { | |||
| feature: /(?<!\S)Feature:/g, | |||
| feature: /(?<!\S)(?:^| )Feature:/gm, | |||
There was a problem hiding this comment.
the regex will match with the following:
some text Feature: descriptionAlso add a test for this case
There was a problem hiding this comment.
@SagarGi Also, add test for the tabs
<tab><tab>Feature: description
|
@SagarGi If the appropriate regex cannot found then one solution would be:
|
|
What is the status of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix this #16.
I have changes the regex for the
Feature:keyword not to count it as when theFeature:is as text