-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update live_user in desktop scripts #200
Conversation
Found liveuser was change to live_user in build.sh, so updated this script to reflect change.
Reviewer's Guide by SourceryThis pull request updates the desktop scripts to align with the build.sh script by changing 'liveuser' to 'live_user' across multiple configuration files. The changes are primarily focused on variable name updates and file path modifications to ensure consistency throughout the system. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vimanuelt - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a centralized configuration or environment variable for the live user name to make future changes easier and less error-prone.
- The commit message could benefit from more detail explaining the motivation behind the change from 'liveuser' to 'live_user'.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vimanuelt - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Found liveuser was change to live_user in the build.sh script. Made changes to the desktop scripts to align with build.sh script.
Summary by Sourcery
Align variable naming in desktop scripts with the build.sh script by changing 'liveuser' to 'live_user'.
Enhancements: