Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update live_user in desktop scripts #200

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Conversation

vimanuelt
Copy link
Contributor

@vimanuelt vimanuelt commented Sep 9, 2024

Found liveuser was change to live_user in the build.sh script. Made changes to the desktop scripts to align with build.sh script.

Summary by Sourcery

Align variable naming in desktop scripts with the build.sh script by changing 'liveuser' to 'live_user'.

Enhancements:

  • Update desktop scripts to use 'live_user' instead of 'liveuser' for consistency with the build.sh script.

Found liveuser was change to live_user in build.sh, so updated this script to reflect change.
@vimanuelt vimanuelt requested review from a team as code owners September 9, 2024 05:26
Copy link
Contributor

sourcery-ai bot commented Sep 9, 2024

Reviewer's Guide by Sourcery

This pull request updates the desktop scripts to align with the build.sh script by changing 'liveuser' to 'live_user' across multiple configuration files. The changes are primarily focused on variable name updates and file path modifications to ensure consistency throughout the system.

File-Level Changes

Change Details Files
Update variable name from 'liveuser' to 'live_user'
  • Replace all occurrences of '${liveuser}' with '${live_user}'
  • Update file paths containing '/home/${liveuser}' to '/home/${live_user}'
  • Modify user creation and configuration commands to use 'live_user'
common_config/autologin.sh
common_config/setuser.sh
desktop_config/mate.sh
desktop_config/mate_oem.sh
desktop_config/xfce.sh
Improve ZFS pool cleanup in build script
  • Add commands to unmount /dev and release directories if mounted
  • Ensure clean export of ZFS pool 'ghostbsd'
build.sh

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vimanuelt - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a centralized configuration or environment variable for the live user name to make future changes easier and less error-prone.
  • The commit message could benefit from more detail explaining the motivation behind the change from 'liveuser' to 'live_user'.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟡 Security: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

desktop_config/mate_oem.sh Show resolved Hide resolved
@ericbsd
Copy link
Member

ericbsd commented Sep 9, 2024

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vimanuelt - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟡 Security: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

build.sh Show resolved Hide resolved
desktop_config/mate_oem.sh Show resolved Hide resolved
Copy link
Member

@ericbsd ericbsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericbsd ericbsd merged commit 328abfa into ghostbsd:master Sep 9, 2024
1 check passed
@ericbsd ericbsd added the bug label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants