-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24.10.1 Base update from FreeBSD #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- s/conficts/conflicts/ (cherry picked from commit 9046ecff409c45205aad34ef8d959d79dd20cf8f)
- s/parametes/parameters/ (cherry picked from commit cc4997907714ec22498a454736974abfbc123beb)
(cherry picked from commit 66fcbd9556b0053253a945638ae360ffc9040c82)
(cherry picked from commit 2912c2fbd44072b7372c24dd34392c01f5104497)
(cherry picked from commit 787259bfe56478b9aa0699f2516d00722b9cc309)
(cherry picked from commit 180c8ab079950acb15c6629ce293055ea0117b39)
(cherry picked from commit 9a49c98bafbea2a896f72defe7d9f2b65a474c41)
(cherry picked from commit b7ea2b69ef666ee8cdc6dcc814d610df0a7f0999)
…off paging (cherry picked from commit 1be58e67eb24024bc808357771579d396679ecb0)
(cherry picked from commit 687b896f8ea58e67c3a0bfbd3af3041733e57dcf)
(cherry picked from commit 280e50461a1f638088e7a0b9116976821c374b56)
(cherry picked from commit 678bc2281c3727e920604545240d9115de3d1bd3)
(cherry picked from commit bbb00b1719f11c58efd5375aebc30ccd13bf0906)
(cherry picked from commit 4f82af24f1113a7df224daded227d4e9de582c0b)
(cherry picked from commit e134cd9580ad62e87c8e8678bdbc45936b11ee86)
(cherry picked from commit 666303f5980896346c455bc949e49952220d02b7)
Reviewed by: zlei MFC after: 1 week Obtained from: OpenBSD, henning <[email protected]>, cf7c0bf78a Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D46576 (cherry picked from commit 50ecaf1bd46a834c4fdaf483eb39df7bb62501e3)
An interface's bpf could feasibly not exist, in which case bpf_peers_present() would panic from a NULL pointer dereference. Solve this by adding a new IfAPI that could deal with a NULL bpf, if such could occur in the network stack. Reviewed by: zlei Sponsored by: Juniper Networks, Inc. MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D42082 (cherry picked from commit 8f31b879ecaf9e738dba631df4606742ee404e8e) bpf: Prefer the boolean form when calling bpf_peers_present() Reviewed by: markj, kp, #network MFC with: 8f31b879ecaf Differential Revision: https://reviews.freebsd.org/D45509 (cherry picked from commit 89204d9dcbe28558fae65936a0e93f44d926b88f)
This comment was introduced by fix [1], later the fix was refined by change [2], and the context of the usage of `m_get2()` and `m_getjcl()` got lost, then the comment became obscure. Update to reflect the current behavior. 1. f13da24 net/bpf: Fix writing of buffer bigger than PAGESIZE 2. a051ca7 Introduce m_get3() Fixes: a051ca7 Introduce m_get3() MFC after: 3 days (cherry picked from commit 343bf78e487190557889c8ba53d8080b268867f7)
This improves readability a little. MFC after: 3 days (cherry picked from commit e30b58846003a54df028686363b5abed59897779)
MFC after: 3 days (cherry picked from commit 1baf6164e4d671ca1547a3096d8ce8fe69ed4e5c)
This update fixes exiting from an interactive bc session with ^D on FreeBSD and Linux when using editline. This bug was caused by the macOS fix for editline in version 7.0.0, which has been reverted in this version. Reported by: [email protected] (cherry picked from commit c2c85f88902d18d2e9702381f1628112e15a5c3c) (cherry picked from commit 9b04aee86ccd58a6f3c936e0cd95bb9305a69848)
The change of its description from integer to boolean didn't actually change it to a boolean, but only made it impossible to set as either a boolean or an integer. Rather than make it work as a boolean parameter should, just revert to the old (working) integer parameter, and change the documentation to match. PR: 274263 Reported by: andrew.hotlab at hotmail (cherry picked from commit ae1a0648b05acf798816e7b83b3c10856de5c8e5)
(cherry picked from commit a6c8ab4f45496d0e7e49ef8ae0c44f39caefd1fa) Fixes: 20191b7 ("src.conf: Add a MK_ZFS_TESTS knob") Sponsored by: The FreeBSD Foundation
Guests must set HDAC_CORBWP less than corb->size. Treat invalid values as an error rather than entering an infinite loop. Reported by: Synacktiv Reviewed by: markj Security: HYP-12 Sponsored by: The Alpha-Omega Project Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D46134 (cherry picked from commit a305f44d1404fbf386bb2b50ab7233ce9eabe0bb)
(cherry picked from commit 4cc4b5e2b5f85f136169069559108ed7fff351f9)
Reviewed by: emaste Fixes: 35e492f ("Update list of Conexant and Realtek codecs.") Differential Revision: https://reviews.freebsd.org/D45965 (cherry picked from commit 4004e1752ec7992eeace7f0318d2ca3fc7ba9e03)
This is a follow-up to commit e72d86ad9c62 ("bhyve: improve input validation in pci_xhci") -- introducing a helper for slot validation. Co-authored-by: John Baldwin <[email protected]> Reviewed by: markj, emaste Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D46696 (cherry picked from commit f505f9a842eb3e75e16e6c7c6f67d5b592b1bc65)
Fix "singleton" function used by regcomp() to turn character set matches into exact character matches if a character set has exactly one element. The underlying cset representation is complex; most critically it records"small" characters (codepoint less than either 128 or 256 depending on locale) in a bit vector, and "wide" characters in a secondary array. Unfortunately the "singleton" function uses to identify singleton sets treated a cset as a singleton if either the "small" or the "wide" sets had exactly one element (it would then ignore the other set). The easiest way to demonstrate this bug: $ export LANG=C.UTF-8 $ echo 'a' | grep '[abà]' It should match (and print "a") but instead it doesn't match because the single accented character in the set is misinterpreted as a singleton. PR: 281710 Reviewed by: kevans, yuripv Obtained from: illumos (cherry picked from commit 8f7ed58a15556bf567ff876e1999e4fe4d684e1d)
That's a pretty old dock for Thinkpad X1 Carbon Gen4 and few others. MFC after: 1 week (cherry picked from commit a1bb5bdb0ab69bc3ce1f6051b6abc0cbaab83faa)
The previous width of Netif (10 or 8) was too short for modern interface names; make it 12, which is long enough to display "epair0a.1000". This came up in practice with genet(4) interfaces, since the base interface name is long enough that with the previous limit, VLAN identifiers would be truncated at 1 character in the IPv6 output: "genet0.100" becomes "genet0.1". The width is now fixed, and doesn't depend on the address family, because there's no reason that length of the interface name would vary based on the AF. Reviewed by: imp,zlei,Mina Galić Pull Request: freebsd/freebsd-src#1223 (cherry picked from commit d33b87e8cf91a6bcb5eac0ecc0371c1041c61050) netstat: for -W, use IFNAMSIZ If -W is specified, use IFNAMSIZ as the width of the Netif column, instead of the default 12. (cherry picked from commit ae9c0ba8ef2f540f9030909cf07e3c59f876fd23)
No functional change intended. MFC after: 1 week (cherry picked from commit 941f8aceac1b6c16ca4d96b52e60ab437c4f9207)
No functional change intended. MFC after: 1 week (cherry picked from commit 89937323bddd41fd8b92430c3ece48d3e32c2c23)
As for the consumer `enc_add_hhooks()`, `hhook_add_hook()` will never fail for the given parameters. Meanwhile, to build the module if_enc(4), at least option INET or INET6 is required, so no need for the error EPFNOSUPPORT. No functional change intended. Reviewed by: ae MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D46770 (cherry picked from commit 7643141e9314f1eac0d9ac08457410509e6829ad)
Mostly white space, style, and luacheck compliance. Signed-off-by: Jose Luis Duran <[email protected]> (cherry picked from commit 504981357aa36365784458cfe8d9e23097bfac7b)
Silence a warning emitted by fread(3) in fstyp(8)'s read_buf(), when detecting the file system type of the cloud-init device: % fstyp /dev/iso9660/cidata fstyp: fread: Invalid argument cd9660 Also rephrase slightly a comment while here. Signed-off-by: Jose Luis Duran <[email protected]> (cherry picked from commit d71e2c037c942dbe2a9fd2630d5cf155dd1bf7db)
Prefer posix.sys.stat's chmod() to os.execute(). While here, change the name of the locals to be more descriptive. Signed-off-by: Jose Luis Duran <[email protected]> (cherry picked from commit 9b2d92addc31ba6f5696c85d184a45d43e9073dc)
Standardize the utilities from nuage.lua, to return nil on failure, plus an error message as a second result, and some value different from nil on success. Make warnmsg() and errmsg() append "nuageinit: " by default. Pass an optional second parameter as false to avoid printing this tag. Signed-off-by: Jose Luis Duran <[email protected]> (cherry picked from commit 945632ca76117029e7bd1f46d17ccb378973daf7)
Signed-off-by: Jose Luis Duran <[email protected]> (cherry picked from commit 38bb6f79e39a14ea99f559f59129a4cadf92b569)
The hashed password usually contains a "$" sign, which, when used on a shell, must be escaped. Also, the plain text password may contain special characters that require escaping. Add a quick fix by enclosing it in single quotes. Note that if the plain text password contains a "'", it will still fail. This will be properly fixed in later commits. Some here documents require the document to be a string literal, especially when passing invalid characters. Enclose it in single quotes. Signed-off-by: Jose Luis Duran <[email protected]> (cherry picked from commit b9ce743c5447e90c2c97f4d49e048c301f708527)
- Export NUAGE_FAKE_ROOTDIR only once - Use the header section of the test to require the root user - Use the PWD environment variable - Set the root/sys shell as /bin/sh - Use RFC 5737 reserved IP addresses Signed-off-by: Jose Luis Duran <[email protected]> (cherry picked from commit e72457c4f5166eef2a27249e02f3c1e9a1cf852d)
- Add the firstboot-freebsd-update package, as long as we do not have pkgbase, this is needed - Support SLAAC by default to complement DHCPv4 (use SYNCDHP instead) Signed-off-by: Jose Luis Duran <[email protected]> (cherry picked from commit 120740221fd4a4577e63e6c279f9873cabe449d0)
[Parallel] Revert sequential task changes https://reviews.llvm.org/D148728 introduced `bool Sequential` to unify `execute` and the old `spawn` without argument. However, sequential tasks might be executed by any worker thread (non-deterministic), leading to non-determinism output for ld.lld -z nocombreloc (see https://reviews.llvm.org/D133003). In addition, the extra member variables have overhead. This sequential task has only been used for lld parallel relocation scanning. This patch restores the behavior before https://reviews.llvm.org/D148728 . Fix #105958 Pull Request: llvm/llvm-project#109084 This fixes the non-reproducibility we had noticed when linking our EFI loaders, and for which we committed a workaround in f5ce3f4ef562. MFC after: 3 days (cherry picked from commit 54521a2ff93ae06c95c31f79f89dc23c9b51c20b)
The upstream fix to make lld output for our EFI loaders reproducible again was committed in 54521a2ff93a. Bump lld's LINKER_FREEBSD_VERSION to be able to check this in the EFI loader Makefile. MFC after: 3 days (cherry picked from commit f97c7fdc59d252cc8611968ffac541d4b8342b8b)
The new sys/conf/std.debug contains the list of debugging options enabled by default in -CURRENT, so they don't need to be listed individually in every kernel config. Introduce *-DEBUG variants of the major kernel configs. (cherry picked and modified from commit 4f8f9d708e6a4143f3b178bfab10d0a9b75ba2fe) Reviewed by: markj, imp, olce (previous version) Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D46871
🧙 Sourcery is reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
vimanuelt
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that was a lot of changes to review. I did not find any discrepancies. Proposed changes made logical sense to be included.
ericbsd
added
documentation
Improvements or additions to documentation
enhancement
and removed
documentation
Improvements or additions to documentation
labels
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.