Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements dragging and dropping subtitles into other applications or local folders #113

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Implements dragging and dropping subtitles into other applications or local folders #113

wants to merge 22 commits into from

Conversation

RickWong
Copy link

  • Implements: Drag subtitles out of Caption & drop them elsewhere
  • Upgrades: Electron 12 (not the latest, but supports Apple silicon)
  • Fixes: several bugs

RickWong added 22 commits April 20, 2022 11:19
@RickWong
Upgrade to Electron 11 for Apple M1 support.
96c9477
@RickWong
Upgrade to Electron 12 to silence contextIsolation warnings.
30db40e 
Upgrade electron-updater to 5.
@RickWong
Ignore JetBrains' .idea/ folder.
c309c9d
@RickWong
Don't destructure a potential null object returned from electron-upda…
331c222 
…ter.
@RickWong
Fix main window's titleBarStyle in newer Electron version.
c74c9e5
@RickWong
Fix client-side webpack require is not defined error by enabling node…
4407d17 
…Integration.
@RickWong
Remove backend JS functions from results, before sending as JSON to f…
7d825cf 
…rontend.
@RickWong
Update code to use Electron's new showSaveDialog API and returned pro…
d600a92 
…mise value.
@RickWong
Prevent new search submitted with Enter key to open save dialog.
598082b
@RickWong
Implemented dragging subtitle from Caption window to drop as a local …
0520237 
…file.
@RickWong
Mark item as downloaded, so the user doesn't have to remember.
267bf4a
@RickWong
Tweak timeout so dropping feels more responsive.
8c3ad19
@RickWong
Fixes multidownload, by passing object shapes expected by caption-cor…
da08aaa 
…e 2.1.1.
@RickWong
Fix searchByQuery by removing backend JS functions from results, befo…
9368c0c 
…re sending as JSON to frontend.
@RickWong
If Caption.searchByFiles doesn't find any subtitles use Caption.searc…
fffabc0 
…hByQuery.
@RickWong
Update Jest snapshots.
575aae0
@RickWong
Fix bug: Allow double clicking first result.
05e4d5c
@RickWong
Use Electron's newer shell.openPath() instead of obsolete shell.openI…
c22a105 
…tem().
@RickWong
Upgrade electron-builder.
1d7cf87
@RickWong
Ensure icon path for dragging can be resolved in production builds.
44e5fa5
@RickWong
Build both x64 and arm64 mac builds.
43f1d33
@RickWong
Only allow dragging of subtitles, not of listed media files.
aaa18d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RickWong