-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualize Hi-C files using Juicebox without relying on an iframe #2106
Draft
luistoptal
wants to merge
38
commits into
gigascience:develop
Choose a base branch
from
luistoptal:new-feature/329-hi-c-data-vis-with-juicebox-integration-or-widgets-e613
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Visualize Hi-C files using Juicebox without relying on an iframe #2106
luistoptal
wants to merge
38
commits into
gigascience:develop
from
luistoptal:new-feature/329-hi-c-data-vis-with-juicebox-integration-or-widgets-e613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/329-hi-c-data-vis-with-juicebox-integration-or-widgets-e613
…re/329-hi-c-data-vis-with-juicebox-integration-or-widgets-e613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue: #329
IMPORTANT: as this is builds on top of #2091, please merge that PR before this one
How to test?
Scenario: Juicebox tab
should passHow have functionalities been implemented?
Both HiGlass and Juicebox were considered. For a comparsion, check the comments in #329
HiGlass looks better, it is more performant, and has more features, but it is also more complex to implement. For our use case juicebox seems to be sufficient
To implement Juicebox, this was taken as a reference: https://github.com/igvteam/juicebox.js/blob/master/examples/juicebox-api.html
Any issues with implementation?
Someone with access to AWS should upload a .hic file for testing purposes and then this would be replaced in the tests. The ideal candidate would be one lightwewight hic file already being used in production
Such files should probably be publicly accessible
Any changes to automated tests?
Added
Scenario: Juicebox tab