Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analyzers #623

Closed
wants to merge 1 commit into from
Closed

Update analyzers #623

wants to merge 1 commit into from

Conversation

64J0
Copy link
Member

@64J0 64J0 commented Oct 24, 2024

Description

With this PR, I'm updating G-Research.FSharp.Analyzers and Ionide.Analyzers nuget package versions, and github/codeql-action/upload-sarif action to v3.

How to test

Check CI.

… versions, and github/codeql-action/upload-sarif action to v3
@64J0 64J0 requested review from nojaf and mrtz-j October 24, 2024 21:45
@64J0 64J0 self-assigned this Oct 24, 2024
@64J0 64J0 marked this pull request as draft October 24, 2024 21:45
@64J0
Copy link
Member Author

64J0 commented Oct 24, 2024

Noticed that it's not working properly yet, so I'll take more time to understand the problem and fix later.

@nojaf
Copy link
Contributor

nojaf commented Oct 25, 2024

You need to bump the tool as well:

 [21:46:33.348] error: Trying to load /home/runner/.nuget/packages/g-research.fsharp.analyzers/0.11.0/analyzers/dotnet/fs/G-Research.FSharp.Analyzers.dll which was built using SDK version 0.27.0.0. Expect 0.26.0.0 instead. Assembly will be skipped.
  [21:46:33.369] error: Trying to load /home/runner/.nuget/packages/ionide.analyzers/0.12.0/analyzers/dotnet/fs/Ionide.Analyzers.dll which was built using SDK version 0.27.0.0. Expect 0.26.0.0 instead. Assembly will be skipped.

@64J0
Copy link
Member Author

64J0 commented Oct 25, 2024

Closing in favor of dependabot PRs.

@64J0 64J0 closed this Oct 25, 2024
@64J0 64J0 deleted the update-analyzers-version branch October 25, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants