Add AssemblyVersion attribute #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@baronfel and @DalekBaldwin, if you have some free time, please take a look at this PR. I think this must be enough to close the issue #521, and later we can revisit this process, to automate it using https://github.com/ionide/KeepAChangelog. |
64J0
force-pushed
the
521-assembly-version-numbers-have-reverted-to-default-1000-ever-since-nuget-version-500-alpha-002
branch
from
375bb27 to
94e310d
Compare
64J0
commented
Nov 17, 2024
| @@ -2,6 +2,7 @@ | |||
| <PropertyGroup> | |||
| <!-- General --> | |||
| <AssemblyName>Giraffe</AssemblyName> | |||
| <AssemblyVersion>7.0.2</AssemblyVersion> | |||
There was a problem hiding this comment.
Another potential fix would be to define this property at the dotnet pack command on CI here https://github.com/giraffe-fsharp/Giraffe/blob/master/.github/workflows/publish.yml#L69
nojaf
approved these changes
Nov 18, 2024
mrtz-j
approved these changes
Nov 18, 2024
64J0
deleted the
521-assembly-version-numbers-have-reverted-to-default-1000-ever-since-nuget-version-500-alpha-002
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR, I'm adding the AssemblyVersion attribute to Giraffe.fsproj, and updating the DEVGUIDE document, adding a new step to update this attribute whenever a new release is intended.
Related issues