add support for binding to a specific interface for url previews #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JadedBlueEyes
temporarily deployed
to
github-pages
GitHub Actions
Inactive
girlbossceo
reviewed
Dec 7, 2024
girlbossceo
reviewed
Dec 7, 2024
JadedBlueEyes
force-pushed
the
url-preview-interface
branch
from
d3d3080 to
35ce502
Compare
girlbossceo
reviewed
Dec 7, 2024
JadedBlueEyes
force-pushed
the
url-preview-interface
branch
from
35ce502 to
6c6ae6e
Compare
JadedBlueEyes
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This is helpful to, for example, bind to an interface that can only access the public internet. The resulting setup is less maintenance-heavy / error-prone than manually maintaining a deny/ allowlist to protect internal resources. Signed-off-by: Jade Ellis <[email protected]>
JadedBlueEyes
force-pushed
the
url-preview-interface
branch
from
6c6ae6e to
52cee65
Compare
JadedBlueEyes
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful to, for example, bind to an interface that can only access the public internet. The resulting setup is less maintenance-heavy / error-prone than manually maintaining a deny/allowlist to protect internal resources.
In my setup, I'm using podman's
macvlandriver to provide direct access to my host'seno1interface, which accesses the public net, like so:This means that the URL preview requests can't access any of my local services or my private network.