-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plantilla genérica de correo electrónico #38
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcbautista
changed the title
new: module with generic email template
Plantilla genérica de correo electrónico
Jul 16, 2024
lcbautista
force-pushed
the
new_generic_email_template
branch
from
July 17, 2024 10:07
d07417c
to
2547459
Compare
lcbautista
force-pushed
the
new_generic_email_template
branch
from
July 17, 2024 10:29
2547459
to
7b9163e
Compare
polsala
approved these changes
Jul 17, 2024
Test Results70 tests 70 ✅ 0s ⏱️ Results for commit 7b9163e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objetivos
Facilitar la creación y modificación de plantillas de correo electrónico
Comportamiento antiguo
Actualmente para crear una plantilla de correo se tiene que "crear" (o hacer un copy-paste de una plantilla existente) de cero todo el cuerpo del correo.
Esto no es eficiente ya que si el estilo del correo (branding) es común para todas las comunicaciones, el día que se quiera realizar alguna modificación se tendrá que ir plantilla por plantilla realizando las modificaciones pertinentes.
Si en cambio se necesita crear una nueva comunicación, se recurrirá al copy-paste el cual puede dar lugar a error.
Comportamiento nuevo
Este módulo implementa una plantilla genérica que permite ser fácilmente editable utilizando los banners y los dominios de banners para tener un contenido personalizable por plantilla.
La plantilla genérica esta constituida por 3 banners que son visibles en el contenido del correo:
generic_email_template_header
generic_email_template_body
generic_email_template_footer
y otros dos que corresponden a "metadatos" del propio correo:
generic_email_template_title
: se utiliza como nombre del HTML generado. No se suele mostrar en los correos pero se ha creado para mantener el estándar HTML.generic_email_template_preheader
: algunos clientes de correo utilizan este tag como un asunto que se visualiza desde el listado de correos. Vendría a ser un "asunto resumido"Un ejemplo de como se puede utilizar esta plantilla la encontraremos en la siguiente pull request: https://github.com/gisce/erp/pull/21041