Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Round Types - Builder, Common, Data-Layer #2949

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

codenamejason
Copy link
Contributor

@codenamejason codenamejason commented Feb 15, 2024

Fixes: #2950
Fixes #2883

  • Removes the graph call for the strategy name.
  • Updates strategy type check in Builder UI project details components.

Description

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 8:43pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 8:43pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 8:43pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 8:43pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 8:43pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 8:43pm

Copy link

gitstream-cm bot commented Feb 15, 2024

🥷 Code experts: 0xKurt, bhargavaparoksham

0xKurt, bhargavaparoksham have most 👩‍💻 activity in the files.
bhargavaparoksham, 0xKurt have most 🧠 knowledge in the files.

See details

packages/builder/src/actions/rounds.ts

Activity based on git-commit:

0xKurt bhargavaparoksham
FEB 62 additions & 280 deletions
JAN 1 additions & 1 deletions
DEC
NOV
OCT 49 additions & 4 deletions
SEP

Knowledge based on git-blame:
0xKurt: 37%
bhargavaparoksham: 14%

packages/builder/src/components/grants/ApplicationCard.tsx

Activity based on git-commit:

0xKurt bhargavaparoksham
FEB 42 additions & 36 deletions
JAN
DEC
NOV
OCT 121 additions & 38 deletions
SEP

Knowledge based on git-blame:
bhargavaparoksham: 35%
0xKurt: 15%

packages/builder/src/components/grants/rounds/RoundListItem.tsx

Activity based on git-commit:

0xKurt bhargavaparoksham
FEB 8 additions & 8 deletions
JAN
DEC
NOV
OCT 116 additions & 26 deletions
SEP

Knowledge based on git-blame:
bhargavaparoksham: 32%
0xKurt: 3%

packages/builder/src/components/grants/stats/Stats.tsx

Activity based on git-commit:

0xKurt bhargavaparoksham
FEB 7 additions & 4 deletions
JAN
DEC
NOV
OCT 28 additions & 19 deletions
SEP

Knowledge based on git-blame:
0xKurt: 82%
bhargavaparoksham: 9%

packages/common/src/index.ts

Activity based on git-commit:

0xKurt bhargavaparoksham
FEB 2 additions & 0 deletions 38 additions & 94 deletions
JAN 24 additions & 0 deletions 2 additions & 0 deletions
DEC 8 additions & 0 deletions
NOV 2 additions & 2 deletions
OCT 23 additions & 17 deletions
SEP

Knowledge based on git-blame:
bhargavaparoksham: 14%
0xKurt: 7%

packages/data-layer/src/queries.ts

Activity based on git-commit:

0xKurt bhargavaparoksham
FEB 60 additions & 0 deletions 68 additions & 5 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
bhargavaparoksham: 18%
0xKurt: 17%

To learn more about /:\ gitStream - Visit our Docs

Copy link

gitstream-cm bot commented Feb 15, 2024

This PR is 25.190839694656486% new code.

@codenamejason codenamejason changed the title Updated Round Types Updated Round Types - Builder, Common, Data-Layer Feb 15, 2024
@thelostone-mc thelostone-mc merged commit 383e196 into main Feb 16, 2024
21 checks passed
@thelostone-mc thelostone-mc deleted the update-round-types branch February 16, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants