[View] cluster 요약에서 cluster의 releaseTag를 보여주는 방식 변경 #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytaek
approved these changes
Oct 7, 2024
| @@ -19,7 +19,7 @@ export type Summary = { | |||
| export type Cluster = { | |||
| clusterId: number; | |||
| summary: Summary; | |||
| latestReleaseTag: string; | |||
| clusterTags: string[]; | |||
| @@ -36,7 +36,7 @@ function tagToNumber(tag: string, maxLength: number): number { | |||
| * @param tags | |||
| * @returns | |||
| */ | |||
| function getCommitLatestTag(tags: string[]): string { | |||
| export function getCommitLatestTag(tags: string[]): string { | |||
There was a problem hiding this comment.
오! 간단한 test case를 만들어보기 좋은 public 함수가 하나 나왔군요!!!
|
확인되셨으면 머지 부탁드리겠습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#727
Result
cluster에 latestReleaseTag 정보를 가지고 display
cluster에 모든 ReleaseTag 정보를 가지고 display할 때 latestReleaseTag 판단
Work list
(with @pithesun)
Discussion
#756 merge 이후 latestReleaseTag 관련 내용 수정 필요