Add .wx extension to Monkey language

[seyhajin]

Added Wonkey extension to Monkey language.

Description

Wonkey is a up to date fork of Monkey2 programming language for the creation of cross-platform video games (very similar to BlitzBasic/BlitzMax but with oriented object programming).

preview:

struct Vec2<T>
    field x:T
    field y:T

    method new( x:T, y:T )
	self.x = x
	self.y = y
    end

    operator+:Vec2( v:Vec2 )
        return new Vec2( x + v.x, y + v.y )
    end

    operator to:string()
        return "Vec2(" + x + ", " + y + ")"
    end
end

alias Vec2<float> Vec2f

'main entry
function main()
   local v0:= new Vec2f( 10,20 )
   local v1:= new Vec2f( 30,40 )
   print v0 + v1
end

Wonkey : https://github.com/wonkey-coders/wonkey
Monkey2 : https://github.com/blitz-research/monkey2

Checklist:

• I am associating a language with a new file extension.
  • The new extension is used in hundreds of repositories on GitHub.com
    • Search results for each extension:
      • https://github.com/search?q=extension%3Awx&type=Code
      • Another users/repos : https://github.com/search?l=&p=2&q=extension%3Awx+-user%3A%22Wonkey-Coders%22&ref=advsearch&type=Code
        • User: https://github.com/abakobo
        • Repo: https://github.com/DoctorWhoof/Wonkey-FPS-Test
  • I have included a real-world usage sample for all extensions added in this PR:
    • Sample source(s): explicitly added in this PR (commit 41e1e81) => samples/Monkey/vec2.wx
    • Sample license(s): Wonkey license
  • I have included a change to the heuristics to distinguish my language from others using the same extension.

[Alhadis]

First, please fill out the pull-request template. It's there for a reason.

Second, a little background on what "Wonkey" is would be nice. I notice that you're adding .wx as an extension, not .wonkey, so adding a link or a short explanation explaining what "Wonkey" is would help to clear up any confusion.

[seyhajin]

OK, i have updated my pull request description with more informations.

[lildude]

• I have included a real-world usage sample for all extensions added in this PR:

No you haven't 😉 Please add the sample to the PR.

[lildude]

I'd add the sample myself, however you've not granted maintainers write access to your branch so I can't. Accordingly, this PR will miss the release I'm making today.

[seyhajin]

No you haven't 😉 Please add the sample to the PR.

@lildude , Ok i added a Vec2 sample

I'd add the sample myself, however you've not granted maintainers write access to your branch so I can't. Accordingly, this PR will miss the release I'm making today.

It seems not possible to "Allow edits from maintainers" from organization account pull request, see https://github.com/orgs/community/discussions/5634.

[lildude]

@lildude , Ok i added a Vec2 sample

Where did you get this from? Please update the OP to link directly to the file.

[seyhajin]

@lildude , Ok i added a Vec2 sample

Where did you get this from? Please update the OP to link directly to the file.

Link updated and i added this file in PR.

[lildude]

Errm, we need a link to the original source, not your fork of Linguist 😉

[seyhajin]

Errm, we need a link to the original source, not your fork of Linguist 😉

Cause i have added this file in this pull request but ok i have changed link from original vec2 source now. :)

[lildude]

Cause i have added this file in this pull request but ok i have changed link from original vec2 source now. :)

🤔 those two files don't match. If you've written the sample explicitly for this PR, then that's fine. You can state that instead of linking to a source.

[seyhajin]

🤔 those two files don't match. If you've written the sample explicitly for this PR, then that's fine. You can state that instead of linking to a source.

I explicitly added a sample file in my linguist fork in the "samples/Monkey/vec2.wx" folder and integrated it into this PR.
What link do you want me to put in this PR?
I updated the link, tell me if it's good

[seyhajin]

Ok for me

[seyhajin]

@lildude Do you expect other actions from me before to merge this PR?

[lildude]

I've finally looked into the usage and there are a couple of issues:

Your search string suggests usage is nowhere near popular enough with only 904 file, most of which are owned by one user. Removing that user gives only 162 files indexed which is a long way from the documented and even temporarily relaxed requirements. I've tried several other combinations of the search for Wonkey specific keywords and I can't find a result that satisfies the requirements. If you can generate a representative search, please do so.

More importantly... inverting your search to exclude the word "import" (and exclude the wonkey-coders user) reveals this is going to misclassify a lot of other users of the .wx extension that are definitely not Wonkey.

In order to prevent this, you're going to need to identify at least one of those languages and add support to this PR along with two representative samples of both languages to ensure the classifier has a chance of getting things right. If the two languages are similar, you will need to implement a heuristic too.

[seyhajin]

I've finally looked into the usage and there are a couple of issues:

Your search string suggests usage is nowhere near popular enough with only 904 file, most of which are owned by one user. Removing that user gives only 162 files indexed which is a long way from the documented and even temporarily relaxed requirements. I've tried several other combinations of the search for Wonkey specific keywords and I can't find a result that satisfies the requirements. If you can generate a representative search, please do so.

More importantly... inverting your search to exclude the word "import" (and exclude the wonkey-coders user) reveals this is going to misclassify a lot of other users of the .wx extension that are definitely not Wonkey.

In order to prevent this, you're going to need to identify at least one of those languages and add support to this PR along with two representative samples of both languages to ensure the classifier has a chance of getting things right. If the two languages are similar, you will need to implement a heuristic too.

Ok i've changed search filters by adding original "Monkey, Monkey2" extensions and removing 'import' keyword because is a same language, only extension name has been simplified for Wonkey.
I find it very complicated just for adding an extension at existing language :-/

[lildude]

Ok i've changed search filters by adding original "Monkey, Monkey2" extensions and removing 'import' keyword because is a same language, only extension name has been simplified for Wonkey.
I find it very complicated just for adding an extension at existing language :-/

It's not that complicated... it's just that we need to ensure each extension meets the popularity requirements before inclusion so adding the Monkey extensions to your query doesn't help illustrate the popularity of the .wx extension 😁. We also need to ensure that other languages that share the extension are not incorrectly classified.

[seyhajin]

It's not that complicated... it's just that we need to ensure each extension meets the popularity requirements before inclusion so adding the Monkey extensions to your query doesn't help illustrate the popularity of the .wx extension 😁. We also need to ensure that other languages that share the extension are not incorrectly classified.

@lildude I've reduced extension filter to only '.wx' and of course, Wonkey is not the only one to use this extension, should we add more code examples to facilitate the classification or it would not be useful?

[lildude]

@lildude I've reduced extension filter to only '.wx' and of course, Wonkey is not the only one to use this extension, should we add more code examples to facilitate the classification or it would not be useful?

Yes. I think we're also going to need to identify the other predominant user of this extension and add support for it with at least two samples to this PR too.

[seyhajin]

@lildude I've reduced extension filter to only '.wx' and of course, Wonkey is not the only one to use this extension, should we add more code examples to facilitate the classification or it would not be useful?

Yes. I think we're also going to need to identify the other predominant user of this extension and add support for it with at least two samples to this PR too.

I added more Wonkey samples

[lildude]

I added more Wonkey samples

Woah! Some of those are bigger than we need. If the diff view collapses the file, it's too big. Please remove these large samples.

You're still going to need to identify the language of at least one other user of the .wx extension and add it as part of this PR.

[seyhajin]

Woah! Some of those are bigger than we need. If the diff view collapses the file, it's too big. Please remove these large samples.

OK i've removed large sample files.

You're still going to need to identify the language of at least one other user of the .wx extension and add it as part of this PR.

I've updated the PR.

[lildude]

You're still going to need to identify the language of at least one other user of the .wx extension and add it as part of this PR.

👆

[lildude]

Closing as the requested changes have not been made in well over a year since being requested. Please open a new PR when you have the time to make the requested changes.