Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URScript language #7144

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add URScript language #7144

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
58deed2
URScript added
EbbeFuglsang Dec 2, 2024
f0b2343
URScript added
EbbeFuglsang Dec 2, 2024
bc0748e
Update lib/linguist/languages.yml
EbbeFuglsang Dec 3, 2024
b0d69d5
URScript heuristics added
EbbeFuglsang Dec 6, 2024
a663fab
URScript fix in README
EbbeFuglsang Dec 6, 2024
11f2efa
specific & test heuristics + language order fixed
EbbeFuglsang Dec 9, 2024
a8217d9
regex fixed for ReDoS vulnerability
EbbeFuglsang Dec 12, 2024
898dd20
regex fixed for linear execution
EbbeFuglsang Dec 12, 2024
6a4714d
Restore vendor/licenses/git_submodule/typst-grammar.dep.yml
EbbeFuglsang Dec 12, 2024
13fdbef
Update lib/linguist/heuristics.yml
EbbeFuglsang Dec 12, 2024
6dbf49f
Update lib/linguist/heuristics.yml
EbbeFuglsang Dec 13, 2024
0fbfdf6
Revert "Update lib/linguist/heuristics.yml"
EbbeFuglsang Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/linguist/heuristics.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@ disambiguations:
- extensions: ['.script']
rules:
- language: URScript
pattern: '^\s*def\s+[a-zA-Z_]\w*\s*\([^)]*\)\s*:[\s\S]*?\send($|\s)'
pattern: '(^\s*|\s+)def\s+[a-zA-Z_]\w*\s*\([^)]*\)\s*:[\s\S]*?\send($|\s)'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary (\s* is zero or more which includes \s+ which is one or more) and introduces a ReDoS.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I reverted the commit.

- extensions: ['.sol']
rules:
- language: Solidity
Expand Down