Remove macos-12 and its variants, deprecated #17838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criemen
reviewed
Oct 25, 2024
.github/workflows/build-ripunzip.yml
Outdated
| @@ -17,7 +17,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu-20.04, macos-12, windows-2019] | |||
| os: [ubuntu-20.04, macos-14, windows-2019] | |||
There was a problem hiding this comment.
This should be the oldest supported version, not the latest (we're building software we want to use on all supported OS, so that's easier to avoid compatibility issues with an old OS rather than a new one)
There was a problem hiding this comment.
Thanks for the heads up, and for the context, it makes a lot of sense
criemen
approved these changes
Oct 25, 2024
| @@ -44,7 +44,7 @@ jobs: | |||
| # without waiting for the macOS build | |||
| build-and-test-macos: | |||
| if: github.repository_owner == 'github' | |||
| runs-on: macos-12-xl | |||
| runs-on: macos-13-xlarge | |||
There was a problem hiding this comment.
This WF I'm not sure whether it should be on 13 or 14, but in the bigger sense it doesn't really matter. Let's keep this as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
All query authors
.qhelp. See the documentation in this repository.Internal query authors only
.ql,.qll, or.qhelpfiles. See the documentation (internal access required).