Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: extract isRef for SelfParam #18294

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

redsun82
Copy link
Contributor

No description provided.

@Copilot Copilot bot review requested due to automatic review settings December 16, 2024 13:25
@github-actions github-actions bot added the Rust Pull requests that update Rust code label Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 15 out of 19 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • rust/ql/.generated.list: Language not supported
  • rust/ql/lib/codeql/rust/elements/SelfParam.qll: Language not supported
  • rust/ql/lib/codeql/rust/elements/internal/SelfParamImpl.qll: Language not supported
  • rust/ql/lib/rust.dbscheme: Language not supported
Comments suppressed due to low confidence (2)

rust/extractor/src/translate/generated.rs:1815

  • [nitpick] The variable name 'is_ref' should be consistent with the naming convention used elsewhere in the code, such as 'is_amp' as seen in the 'property_name' function.
let is_ref = node.amp_token().is_some();

rust/schema/ast.py:543

  • [nitpick] The attribute name 'is_ref' should be more descriptive to indicate it represents a reference. Consider renaming it to 'is_reference'.
is_ref: predicate

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

Copy link
Contributor

@paldepind paldepind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks.

@redsun82 redsun82 merged commit d624670 into main Dec 16, 2024
15 checks passed
@redsun82 redsun82 deleted the redsun82/extract-self-param-ref branch December 16, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants