Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Cargo.lock #1437

Closed
wants to merge 1 commit into from
Closed

add Cargo.lock #1437

wants to merge 1 commit into from

Conversation

marti1125
Copy link

Generated by Cargo

@arcresu
Copy link
Contributor

arcresu commented Mar 31, 2015

Thanks! Could you explain why this file needs to be ignored? If as the name suggests this is something like ruby's Gemfile.lock then it might not be a good idea to ignore it.

@marti1125
Copy link
Author

the reason is after run $ cargo build
it will generate automatic Cargo.lock with this content:

[root]
name = "hello_world"
version = "0.0.1"

@arcresu
Copy link
Contributor

arcresu commented Apr 1, 2015

Ok, but I assume that this isn't a completely arbitrary file. What is it intended to do?

@marti1125
Copy link
Author

this can help :D
rust-lang/cargo#315

@arcresu
Copy link
Contributor

arcresu commented Apr 2, 2015

From the documentation linked to from the PR you mentioned, it seems that you definitely do want to check this file in unless you're working on a library. I think maybe a better change would be to add the rule commented out with a note to uncomment it if you're developing a library.

@shiftkey
Copy link
Member

@marti1125 unfortunately this isn't mergeable currently, and there are some questions outstanding which we'd like to clarify before merging 😢

I need to clean up stale pull requests at some stage, and will close this out if I don't hear anything before Friday 26th February.

@shiftkey
Copy link
Member

Nevermind, this has already been incorporated: https://github.com/github/gitignore/blob/master/Rust.gitignore#L13-L15

@shiftkey shiftkey closed this Jan 27, 2016
@marti1125
Copy link
Author

ok :D 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants