Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement permission handling #22

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

gitkrakel
Copy link
Contributor

src/background.ts Outdated Show resolved Hide resolved
@gitkrakel gitkrakel force-pushed the GKCS-5331-gkbe-implement-proper-permissi branch from c5e797e to 6c71fbf Compare February 28, 2024 01:53
@jdgarcia
Copy link
Contributor

jdgarcia commented Mar 1, 2024

If you saw my previous comments: I built on the wrong branch 🙃
It works great!

src/domUtils.ts Outdated Show resolved Hide resolved
src/gkApi.ts Outdated Show resolved Hide resolved
@gitkrakel gitkrakel force-pushed the GKCS-5331-gkbe-implement-proper-permissi branch from 4f2229f to 09b099c Compare March 1, 2024 02:45
@gitkrakel gitkrakel requested a review from jdgarcia March 1, 2024 02:45
@gitkrakel gitkrakel merged commit d3640fe into main Mar 1, 2024
1 check passed
@gitkrakel gitkrakel deleted the GKCS-5331-gkbe-implement-proper-permissi branch March 1, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants