Refresh provider token if it is expired #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitkrakel
approved these changes
Apr 26, 2024
src/gkApi.ts
Outdated
| @@ -138,7 +159,12 @@ export const fetchProviderToken = async (provider: Provider) => { | |||
| } | |||
|
|
|||
| const payload = await res.json(); | |||
| return payload.data as ProviderToken; | |||
| const providerToken = payload.data as ProviderToken; | |||
| if (providerToken.expiresIn < 0 && providerToken.type === 'oauth' && provider !== 'github') { | |||
There was a problem hiding this comment.
wondering why we are excluding github here explicitly?
There was a problem hiding this comment.
GitHub tokens don't need to be refreshed, they don't expire
There was a problem hiding this comment.
I can add a comment
There was a problem hiding this comment.
ah it's just the way it's written is weird, cause it checks github at the end after it already checks expiresIn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitLab, Bitbucket, and Azure stop working after a few hours since their tokens need to be refreshed. This is similar to what gk.dev does.