Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Open with GitKraken" link to Focus View PRs #34

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Conversation

jdgarcia
Copy link
Contributor

Attempts to share code with the injection hosts turned out to be more complicated than I realized when I discovered that literally only the contents of injectionScope get injected and anything outside of it (such as imports) do not. Instead, I just ended up writing a "light" version of the existing getRedirectUrl functions that just handle PRs and don't check for things in DOM.

Copy link
Collaborator

@miggy-e miggy-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with a gh pr, azure pr, bitbucket pr

@jdgarcia jdgarcia merged commit 9274ac0 into main Apr 27, 2024
1 check passed
@jdgarcia jdgarcia deleted the open-with-gk branch April 27, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants